Re: Including Firebug Lite As A Feature In Shindig-Extras

2011-09-29 Thread Ryan J Baxter
Already have code mocked up, its actually very simple. Got to love the easy features that give you such a big payoff! -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile From: John Hjelmstad To: dev@shindig.apache.org, Date: 09/29/2011 07:14 PM Subject:

Re: Including Firebug Lite As A Feature In Shindig-Extras

2011-09-29 Thread Henry Saputra
+1 for this. Thanks for the init the effort - Henry On Wed, Sep 28, 2011 at 1:20 PM, Ryan J Baxter wrote: > Firebug lite is a great tool when you are using browsers that do not have > firebug.  Including it as a feature would allow containers and gadgets to > request that feature to allow easier

Re: OAuth 2.0 Service Provider Last Call

2011-09-29 Thread Henry Saputra
Eric, looks like it has not been updated with patch to address the review comments? - Henry On Thu, Sep 29, 2011 at 7:28 AM, Eric Woods wrote: > It has been a week since the OAuth 2.0 service provider code has been updated > to address feedback.  I'd like to make a last call for additional revi

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/#review2165 --- So much code =) Just initial review. http://svn.apache.org/repos/asf

Re: Including Firebug Lite As A Feature In Shindig-Extras

2011-09-29 Thread John Hjelmstad
2c, I've been hoping someone would get around to this idea at some point. +1! On Wed, Sep 28, 2011 at 1:20 PM, Ryan J Baxter wrote: > Firebug lite is a great tool when you are using browsers that do not have > firebug. Including it as a feature would allow containers and gadgets to > request th

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-29 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2166 --- We also had some conversation about simplifying the deny allow lists

Re: Review Request: Gadget Administration - Securing Features and RPC

2011-09-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1666/#review2160 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

RE: Review Request: Common container currently doesnt include the siteId (moduleId) in any of it's security token processing/handling

2011-09-29 Thread Ryan J Baxter
I was having trouble trying to grasp a lot of the changes but one of the over arching questions I have is does a module id necessarily equal a site id? Could a module id be something else? -Ryan Email: rjbax...@us.ibm.com Phone: 978-899-3041 developerWorks Profile From: "Ciancetta, Jesse

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-29 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/#review2157 --- This is my quick review. I am not expert on OAuth2 so this was purely

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

2011-09-29 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-09-29 17:03:35.492298) Review request for shindig, Paul Lindner, j

RE: Review Request: Common container currently doesnt include the siteId (moduleId) in any of it's security token processing/handling

2011-09-29 Thread Ciancetta, Jesse E.
Sounds good -- thanks Ryan. Just to clarify though -- I'm not necessarily suggesting that these changes actually get applied as is -- I'm really more looking to start a discussion around this as one possible solution to the problem. This is the simplest set of changes I could come up with to g

OAuth 2.0 Service Provider Last Call

2011-09-29 Thread Eric Woods
It has been a week since the OAuth 2.0 service provider code has been updated to address feedback. I'd like to make a last call for additional reviews. Feedback permitting, I'd like to commit the service provider work to Shindig by EOD Friday (9/30). OAuth 2.0 JIRA Review: https://reviews.apac

Re: Inline rendering and 3.0 Release

2011-09-29 Thread Michael Beaver
It's applicable to the current trunk, and you should be able to apply it to fairly recent extracts of trunk as well. Michael Beaver IBM Lotus 919-254-7007 (T/L 444) |> | From: | |> >

Re: Inline rendering and 3.0 Release

2011-09-29 Thread Rob Keane
Is the 3.0 patch meant to be applied to a tag? A point in time on the trunk? Thanks! On Sep 28, 2011, at 3:19 PM, Michael Beaver wrote: > Hey, Kevin. I've attached 2 versions of the inline patch to the jira site > for inline: https://issues.apache.org/jira/browse/SHINDIG-1402 > > > We're

Allowing non-page owners to approve OAuth access token?

2011-09-29 Thread Dennis Ju
Hello, I want to allow viewers to approve OAuth tokens for pages where they are not the owner. Basically, we have a requirement to allow users to view OAuth gadgets on a shared page. I set "shindig.signing.viewer-access-tokens-enabled=true" in shindig.properties "to allow the use of 3-legged OAut