Re: Review Request: Remove System.out.println from OAuth2ServiceImpl

2011-10-14 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2387/#review2604 --- Ship it! +1 - Henry On 2011-10-14 18:40:11, Ryan Baxter wrote: >

Re: Review Request: Improvements to shindig log messages

2011-10-14 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2345/#review2602 --- Ship it! Committed revision 1183491. Please close review and JIRA. -

RE: Container Config / Provider Pattern

2011-10-14 Thread Ciancetta, Jesse E.
I put together a quick prototype to demonstrate what I was thinking and published it here: https://reviews.apache.org/r/2390/ You should be able to apply that patch to trunk and then build/deploy, and every 30 seconds you should see something on the console from the BlobCrypterSecurityTokenCod

Re: Review Request: minor fix to allow EE and Action/Selection Sample to run under any context root out of box

2011-10-14 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2052/#review2596 --- Ship it! Committed revision 1183460. - Ryan On 2011-10-14 18:01:40

Review Request: Remove System.out.println from OAuth2ServiceImpl

2011-10-14 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2387/ --- Review request for shindig and Eric Woods. Summary --- There is a system.ou

RE: Failing to connect to https server through gadget

2011-10-14 Thread Tony Chan (tchan2)
Hi Jesse, Thanks for all the help. It turns out my big issues were getting the right certificate and I had a problem with the headers I was sending. After getting those 2 things sorted out, I am able to get a response from my server. I helped one of my teammates set it up (she had a clean install

Re: Container Config / Provider Pattern

2011-10-14 Thread Stanton Sievers
Dan, I don't think we want to type the Classes you've proposed. Imagine a scenario where I want to create a provider that provides for different pieces of information: a String, a Boolean, a File, and an int. Typing would restrict doing that. I think the real value of this idea comes into pla

Re: Review Request: minor fix to allow EE and Action/Selection Sample to run under any context root out of box

2011-10-14 Thread li xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2052/ --- (Updated 2011-10-14 18:01:40.220430) Review request for shindig, Paul Lindner, H

Container Config / Provider Pattern

2011-10-14 Thread Dan Dumont
I think we should probably move this to the dev list and out of the review. For those interested, the conversation started here: https://reviews.apache.org/r/2362/ Jesse, I agree something should be done to make dealing with the container config easier. I just don't think it's going to be pos

Re: Review Request: minor fix to allow EE and Action/Selection Sample to run under any context root out of box

2011-10-14 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2052/#review2587 --- /trunk/content/samplecontainer/examples/conservcontainer/index.html <

RE: Failing to connect to https server through gadget

2011-10-14 Thread Ciancetta, Jesse E.
Hi Tony, Good to hear that the sample application worked, but all I was really trying to give you with that reference was how to turn on the tracing in the java.net API's -- so basically just using the "-Djavax.net.debug=all" flag when firing up the JVM running tomcat. I just ran through it my