Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
> On 2011-10-20 20:45:34, Jesse Ciancetta wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java, > > line 24 > > > > > > Unused import fixed > On 2011-10-20 20:45:34, Jesse C

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2724 --- Ship it! - Henry On 2011-10-20 18:54:27, Paul Lindner wrote: > > -

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2722 --- Ship it! Found a few small items which I noted -- other than those LG

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2718 --- Ship it! LGTM - Ryan On 2011-10-20 18:54:27, Paul Lindner wrote: >

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Dan Dumont
> On 2011-10-20 18:09:06, Dan Dumont wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewritePath.java, > > line 58 > > > > > > StringBuilder? > > Paul Lindner wrote: > nah. Why not?

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/ --- (Updated 2011-10-20 18:54:27.879369) Review request for shindig. Summary -

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
> On 2011-10-20 18:09:06, Dan Dumont wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJslInfoVariableProcessor.java, > > line 89 > > > > > > Is there a performance implication here? I actual

Re: Memory concerns: what is the "normal" amount of CssTree.RuleSet objects to see at runtime

2011-10-20 Thread Stanton Sievers
If I'm reading the ehcacheConfig.xml file correctly, the cached entries don't expire after a given time. Instead, the cache has a max element size of 1000 and once that limit is reached the least recently used elements will be expelled from the cache. And to give closure to the problem I initi

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2708 --- I've also been meaning to ask you about the whitespace nits. Is there

Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/ --- Review request for shindig. Summary --- Java hygiene for shindig * Fix jav

Re: Review Request: Security Token Cleanup in preparation for ContainerConfig controlled token expirations

2011-10-20 Thread Matt Marum
> On 2011-10-19 21:05:16, Matt Marum wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java, > > line 22 > > > > > > Import flux. Ecl

Re: Regarding Open Social 2.0 Implementation in Shindig

2011-10-20 Thread Lalaji Sureshika
Hi Eric, Thanks a lot for your helpful explanation.And yet I'm learning the Opensocail concepts.Hence I hope if I ask more three questions,it will be ok.My questions are inline with your comments. On Thu, Oct 20, 2011 at 12:45 AM, Eric Woods wrote: > Hi Lalaji, > > I'm the primary implementor o

Re: Review Request: Security Token Cleanup in preparation for ContainerConfig controlled token expirations

2011-10-20 Thread Dan Dumont
> On 2011-10-19 21:05:16, Matt Marum wrote: > > Just some nitpicks. I'm good with the changes. > > > > I wish I knew if there was some special motivation in timestamping the > > blobs as the means of enforcing expiration. If anybody has a problem with > > changing this, now would be a good

Re: Review Request: Security Token Cleanup in preparation for ContainerConfig controlled token expirations

2011-10-20 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2396/ --- (Updated 2011-10-20 12:56:57.693241) Review request for shindig, Matt Marum, Rya

Re: Memory concerns: what is the "normal" amount of CssTree.RuleSet objects to see at runtime

2011-10-20 Thread Stanton Sievers
Good find Jas. What is the expected usage pattern for the MessageQueue that gets passed in? Can you write up a Shindig JIRA for how a "real" implementation should work. Or is using a DevNullMQ ok by default? I'm just trying to understand the implications. Thanks, -Stanton From: ๏̯͡๏ Jas

R: Regarding Open Social 2.0 Implementation in Shindig

2011-10-20 Thread Goix Laurent Walter
Hi Eric, Do you have any news on such support for the PHP stack? Cheers walter -Messaggio originale- Da: Eric Woods [mailto:woods...@gmail.com] Inviato: mercoledì 19 ottobre 2011 22.15 A: dev@shindig.apache.org Oggetto: Re: Regarding Open Social 2.0 Implementation in Shindig Hi Lalaji,