+1 LGTM. Thanks Paul.
-Ryan
Email: rjbax...@us.ibm.com
Phone: 978-899-3041
developerWorks Profile
From: "Ciancetta, Jesse E."
To: "dev@shindig.apache.org" ,
Date: 11/02/2011 01:43 PM
Subject:RE: [VOTE] Release Apache Shindig Version 3.0.0-beta3
+1
I downloaded and deploy
Hi Henry,
I don't think I have a particular scenario for global contributors. I was
simply playing around with the code to further my understanding. As part
of that I ran into this problem.
Thanks,
-Stanton
From: Henry Saputra
To: dev@shindig.apache.org,
Date: 11/02/2011 14:17
Su
Hi Stanton,
I dont think the order of the contributors is necessary here so change
it to Set should be fine. What scenario you have in mind to do this?
- Henry
On Wed, Nov 2, 2011 at 4:09 AM, Stanton Sievers wrote:
> Thanks for finding that thread. That is the exact problem I'm running
> into.
+1
I downloaded and deployed the WAR from the staging repository and tested a few
gadgets using the sample container -- looks good.
I also built from SVN source using the shindig-project-3.0.0-beta3 tag,
deployed and did the same tests as above -- looks good.
Thanks to Paul for getting this ou
Yeah, the change was to the OAuth guice bindings that didn't make their way
into java/samples. I fixed that up a few days back.
3.0.0-beta3 is up, test it out!
On Tue, Nov 1, 2011 at 6:34 PM, Ryan J Baxter wrote:
> Paul I am not sure how those changes are causing those tests to fail. They
> w
> On 2011-11-02 00:28:45, Ryan Baxter wrote:
> > One small nit, otherwise LGTM
Committed revision 1196683.
- Ryan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2648/#review3003
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2648/#review3012
---
Ship it!
LGTM!
- Dan
On 2011-11-01 18:12:28, Stanton Sievers wrote
> On 2011-11-01 19:00:41, Jesse Ciancetta wrote:
> > This looks good to me, however if we're going to go this route I wouldn't
> > mind seeing the BlobCrypterSecurityTokenCodec changed to always expect to
> > get the actual token key from ContainerConfig -- and then making the code
> > that pa
Thanks for finding that thread. That is the exact problem I'm running
into. As the thread suggests and as I've confirmed with some simple
testing, annotations solve the problem.
-Stanton
From: "Ciancetta, Jesse E."
To: "dev@shindig.apache.org" ,
Date: 11/02/2011 01:04
Subject:
Hi,
I've prepped version 3.0.0-beta3 for release.
Staging
repo:https://repository.apache.org/content/repositories/orgapacheshindig-141/
Web site:http://shindig.apache.org/
Please evaluate this beta release for quality and suitability.
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
--
Pa
10 matches
Mail list logo
