Re: Review Request: rpc does not support communicating with gadget created on an dom node in existing iframe

2012-02-29 Thread Yao Zhang
> On 2012-02-15 14:43:55, Dan Dumont wrote: > > Could you please provide a bit more information on the use case that you > > are trying and what's going on? I want to make sure I understand this > > before I review. > > > > Also, there's a bunch of whitespace that needs to be cleaned up. Ple

Re: Review Request: rpc does not support communicating with gadget created on an dom node in existing iframe

2012-02-29 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/ --- (Updated 2012-03-01 06:29:05.314946) Review request for shindig, Henry Saputra,

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

2012-02-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5475 --- If there are no other questions/issues I'll go ahead and commit this t

Re: Review Request: Cleanup open view APIs

2012-02-29 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4077/#review5472 --- Ship it! Committed revision 1295336. - Ryan On 2012-02-28 22:28:58

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

2012-02-29 Thread Stanton Sievers
> On 2012-02-29 21:43:25, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java, > > line 563 > > > > > > Wouldnt we w

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

2012-02-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5469 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

2012-02-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/ --- (Updated 2012-02-29 21:30:23.106625) Review request for shindig, li xu and Adam

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

2012-02-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5467 --- Ship it! +1 - Henry On 2012-02-21 21:40:31, Stanton Sievers wrote:

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

2012-02-29 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5466 --- Ship it! OAuth 2.0 spec says response codes from the resource server

Re: Review Request: Pass more information into some lifecycle event listeners.

2012-02-29 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4090/#review5457 --- Ship it! Committed r1295130 - Dan On 2012-02-29 14:30:11, Dan Dumo

Re: Review Request: Pass more information into some lifecycle event listeners.

2012-02-29 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4090/ --- (Updated 2012-02-29 14:30:11.440540) Review request for shindig, Ryan Baxter and

Re: Review Request: Cleanup open view APIs

2012-02-29 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4077/#review5454 --- Ship it! LGTM - Stanton On 2012-02-28 22:28:58, Ryan Baxter wrote: