Re: [VOTE] Apache Shindig release 2.5.0-beta1

2012-03-27 Thread Ate Douma
+1 (non binding) Ate On 03/26/2012 08:25 PM, Henry Saputra wrote: Hi All, Paul Lindner has prepared a release candidate for Shindig 2.5.0-beta1. Staging repo: https://repository.apache.org/content/repositories/orgapacheshindig-114/ SVN tag: http://svn.apache.org/repos/asf/shindig/tags/sh

Re: [VOTE] Apache Shindig release 2.5.0-beta1

2012-03-27 Thread Paul Lindner
Looked for red flags, didn't find any. +1 from me. On Tue, Mar 27, 2012 at 11:30 AM, daviesd wrote: > +1 (tested with our project and all is well) > > > On 3/26/12 2:25 PM, "Henry Saputra" wrote: > > > Hi All, > > > > Paul Lindner has prepared a release candidate for Shindig 2.5.0-beta1. > >

Re: Do not insert carriage return characters (^M) in Shindig files, Windows users please make sure your editor set properly to not inject carriage return char

2012-03-27 Thread Paul Lindner
This config file is used when you add new files to svn. That's where the problem occurs. On Tue, Mar 27, 2012 at 7:42 AM, Dan Dumont wrote: > If everyone uses this config, doesn't that make the editor changes Henry > suggested unnecessary? > I thought that was the point of the eol settings in s

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Henry Saputra
> On 2012-03-27 20:24:42, Dan Dumont wrote: > > So I've been looking at this a bit more because something came up where > > I'll probably have to start using it. > > > > IT made me thing that instead of > > this.loadingGadgetEl_ = args['bufferEl']; > > > > it might be better to pass in a Hol

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4486/#review6443 --- So I've been looking at this a bit more because something came up wher

Re: No longer building 2.5.0-SNAPSHOT artifacts

2012-03-27 Thread Paul Lindner
oh yes, that's my mistake, if you could please fix that I'd appreciate it. If not I can get to it later tonight. On Tue, Mar 27, 2012 at 10:38 AM, Henry Saputra wrote: > I think so, +1 for change the version back to 2.5.0-SNAPSHOT > > - Henry > > On Tue, Mar 27, 2012 at 8:39 AM, Stanton Sievers

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Henry Saputra
> On 2012-03-27 17:18:31, Dan Dumont wrote: > > LGTM Cool, thanks for the review. Committed as revision 1305953. - Henry --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4486/#review6430 -

Re: [VOTE] Apache Shindig release 2.5.0-beta1

2012-03-27 Thread daviesd
+1 (tested with our project and all is well) On 3/26/12 2:25 PM, "Henry Saputra" wrote: > Hi All, > > Paul Lindner has prepared a release candidate for Shindig 2.5.0-beta1. > > Staging repo: >  https://repository.apache.org/content/repositories/orgapacheshindig-114/ > > SVN tag: > http://sv

Re: No longer building 2.5.0-SNAPSHOT artifacts

2012-03-27 Thread Henry Saputra
I think so, +1 for change the version back to 2.5.0-SNAPSHOT - Henry On Tue, Mar 27, 2012 at 8:39 AM, Stanton Sievers wrote: > It looks like changes made to the pom files for 2.5.0-beta1 were reverted > back to "2.5.0" instead of "2.5.0-SNAPSHOT".  I'm assuming this wasn't > intentional and will

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4486/#review6431 --- Thanks for working on this! - Dan On 2012-03-27 16:09:19, Henry Sap

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4486/#review6430 --- Ship it! LGTM - Dan On 2012-03-27 16:09:19, Henry Saputra wrote: >

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4486/ --- (Updated 2012-03-27 16:09:19.774748) Review request for shindig and Dan Dumont.

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Henry Saputra
> On 2012-03-26 18:54:24, Dan Dumont wrote: > > trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js, > > line 140 > > > > > > I didn't get the reasoning behind changing this. > > > >

No longer building 2.5.0-SNAPSHOT artifacts

2012-03-27 Thread Stanton Sievers
It looks like changes made to the pom files for 2.5.0-beta1 were reverted back to "2.5.0" instead of "2.5.0-SNAPSHOT". I'm assuming this wasn't intentional and will change the pom files to build SNAPSHOT artifacts if no one objects. Thanks, -Stanton

Re: Do not insert carriage return characters (^M) in Shindig files, Windows users please make sure your editor set properly to not inject carriage return char

2012-03-27 Thread Dan Dumont
If everyone uses this config, doesn't that make the editor changes Henry suggested unnecessary? I thought that was the point of the eol settings in svn, though I'm not terribly familiar with the setting and any caveats there are with it. I'm not particularly fond of carriage returns, but should

Re: Review Request: Buggy behavior with gadgets tests in EndToEndTest.java

2012-03-27 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4521/#review6427 --- Ship it! LGTM Evgeny, thanks! Since it is already in, please close t

RE: [VOTE] Apache Shindig release 2.5.0-beta1

2012-03-27 Thread Ryan J Baxter
+1 Saw some small problems in the container services container, but they are container implementation issues and not issues in the feature code. -Ryan From: "Ciancetta, Jesse E." To: "dev@shindig.apache.org" , Date: 03/27/2012 07:38 AM Subject:RE: [VOTE] Apache Shindig rele

RE: Shindig running on different domain than container REVISITED

2012-03-27 Thread Dan Dumont
What about the osapi calls like osapi.http that go to the container and then to the shindig server? From: "Ciancetta, Jesse E." To: "dev@shindig.apache.org" , Date: 03/27/2012 08:03 AM Subject:RE: Shindig running on different domain than container REVISITED I've been meani

Re: Review Request: Buggy behavior with gadgets tests in EndToEndTest.java

2012-03-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4521/#review6426 --- Ship it! LGTM In case others aren't familiar with the method: http:

Re: Review Request: Cleanup the sites and holder close flow to delegate removing iframe of the gadget wrapper element to the holder from site responsibility

2012-03-27 Thread Dan Dumont
> On 2012-03-26 18:54:24, Dan Dumont wrote: > > trunk/features/src/test/javascript/features/container.url/url_site_test.js, > > line 83 > > > > > > Hmm, can we replace this test with another one? Why did this fail? > >

Re: Shindig running on different domain than container REVISITED

2012-03-27 Thread Dan Dumont
I really think it should be if it's not. From: daviesd To: , Date: 03/26/2012 05:01 PM Subject:Re: Shindig running on different domain than container REVISITED One other thing (if it helps). I see gadgets that don't do makeRequest fail as follows: Unsafe JavaScript attem

RE: Shindig running on different domain than container REVISITED

2012-03-27 Thread Ciancetta, Jesse E.
I've been meaning to respond to this thread for a while but have been heads down on another project... Another option is to embed all of the data that common container usually tries to fetch via XHR directly into the initial response of your container page. That's the way we do it in Rave and I

RE: [VOTE] Apache Shindig release 2.5.0-beta1

2012-03-27 Thread Ciancetta, Jesse E.
+1 LGTM Thanks Paul and Henry. >-Original Message- >From: Henry Saputra [mailto:henry.sapu...@gmail.com] >Sent: Monday, March 26, 2012 2:26 PM >To: dev@shindig.apache.org >Subject: [VOTE] Apache Shindig release 2.5.0-beta1 > >Hi All, > >Paul Lindner has prepared a release candidate for S

Review Request: Buggy behavior with gadgets tests in EndToEndTest.java

2012-03-27 Thread Evgeny Bogdanov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4521/ --- Review request for shindig. Summary --- Patch for this issue: https://issue