Review Request: Refactor DefaultRequestPipeline to be eaiser to be overridden by breaking the long execute method to small protected methods

2012-04-11 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4706/ --- Review request for shindig. Summary --- Refactor DefaultRequestPipeline to

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

2012-04-11 Thread Yao Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4680/ --- (Updated 2012-04-12 01:47:45.851337) Review request for shindig, Ryan Baxter, Er

Review Request: Add "rpctoken" url fragment to support flash transport if not available in the url metadata when generating gadget iframe url

2012-04-11 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4703/ --- Review request for shindig. Summary --- Add rpctoken in the url fragment to

Re: OAuth enable in Shindig

2012-04-11 Thread Henry Saputra
Hey, I believe you are talking about OAuth1.0 version? Please take a look at the Shindig wiki page: https://cwiki.apache.org/SHINDIG/enabling-oauth-support.html Hope this helps and would love feedback on what portion of it does not work. - Henry On Tue, Apr 10, 2012 at 2:50 AM, witz.hsiao wrot

Re: Review Request: AbstractLockedDomainService has a protected enabled variable as well as a public isEnabled method

2012-04-11 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4698/#review6858 --- Ship it! +1 - Stanton On 2012-04-11 16:22:00, Ryan Baxter wrote: >

Re: Review Request: AbstractLockedDomainService has a protected enabled variable as well as a public isEnabled method

2012-04-11 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4698/#review6855 --- Ship it! LGTM - Dan On 2012-04-11 16:22:00, Ryan Baxter wrote: >

Re: Review Request: AbstractLockedDomainService has a protected enabled variable as well as a public isEnabled method

2012-04-11 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4698/#review6854 --- Ship it! +1 - Henry On 2012-04-11 16:22:00, Ryan Baxter wrote: >

Re: Review Request: AbstractLockedDomainService has a protected enabled variable as well as a public isEnabled method

2012-04-11 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4698/#review6852 --- Ship it! LGTM - Jesse On 2012-04-11 16:22:00, Ryan Baxter wrote: >

Review Request: AbstractLockedDomainService has a protected enabled variable as well as a public isEnabled method

2012-04-11 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4698/ --- Review request for shindig, Stanton Sievers and Dan Dumont. Summary --- Abs

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

2012-04-11 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/ --- (Updated 2012-04-11 14:57:33.421695) Review request for shindig. Changes -

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

2012-04-11 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/ --- (Updated 2012-04-11 14:55:54.729162) Review request for shindig, Ryan Baxter and

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

2012-04-11 Thread Ryan Baxter
> On 2012-04-11 13:57:09, Ryan Baxter wrote: > > Forgot to say LGTM - Ryan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/#review6845 ---

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

2012-04-11 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/#review6845 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

2012-04-11 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/ --- (Updated 2012-04-11 12:51:08.982077) Review request for shindig. Changes -

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

2012-04-11 Thread Dan Dumont
> On 2012-04-11 11:20:18, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js, > > line 68 > > > > > > Whitespace Oh

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

2012-04-11 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/#review6838 --- Looks like some things were missed when pulling the results feature ou