Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-05-04 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/ --- (Updated 2012-05-04 17:50:16.817783) Review request for shindig and Ryan Baxter.

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-05-04 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/#review7571 --- LGTM, besides the JS doc. I applied the patch build, and tested every

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-05-04 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/ --- (Updated 2012-05-04 16:29:28.042006) Review request for shindig and Ryan Baxter.

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-05-04 Thread Henry Saputra
> On 2012-05-04 15:10:34, Ryan Baxter wrote: > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js, > > line 160 > > > > > > you should just return null, or you can let t

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-05-04 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/#review7557 --- trunk/content/samplecontainer/examples/embeddedexperiences/EEContaine

Re: Review Request: Allow gadgets to properly manage/scroll the content area they have been afforded by the container.

2012-05-04 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4973/#review7560 --- Ship it! Committed r1333997 - Dan On 2012-05-03 14:54:20, Dan Dumo

Re: Review Request: Jira 1732 and lots of other fixes/enhancements

2012-05-04 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4947/ --- (Updated 2012-05-04 14:31:05.271804) Review request for shindig, Ryan Baxter and

Re: Review Request: Allow gadgets to properly manage/scroll the content area they have been afforded by the container.

2012-05-04 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4973/#review7558 --- Ship it! LGTM - Ryan On 2012-05-03 14:54:20, Dan Dumont wrote: >

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-05-04 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/ --- (Updated 2012-05-04 07:28:05.434413) Review request for shindig and Ryan Baxter.

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

2012-05-04 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/ --- (Updated 2012-05-04 07:25:24.161034) Review request for shindig and Ryan Baxter.