How long is the beta?

2012-05-22 Thread Joel Cairney
Hi all, How long will shindig 2.5.0 be in beta? I probably won't be able to convince my company to upgrade to the latest shindig for some features we need until 2.5.0 is out of beta. Joel

Review Request: Update Caja integration

2012-05-22 Thread Felix Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5202/ --- Review request for shindig and Jasvir Nagra. Summary --- Shindig's Caja int

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/#review8050 --- I will do a more in depth review tomorrow, but I noticed one small nit

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/#review8041 --- Ship it! LGTM. The sparklr sample works great and helps to tie toget

Re: Securing Oauth 1 secrets

2012-05-22 Thread A Clarke
Mike, Your OAuthStore is responsible for encrypting/decrypting the secrets. The OAuth2Encrypter interface is there because of the lessons learned from writing custom OAuth 1 stores. On Tue, May 22, 2012 at 2:43 PM, Michael Matthews wrote: > I'm adding an OAuth 1.0 OAuthStore implementation t

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Henry Saputra
> On 2012-05-22 18:13:21, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java, > > line 74 > > > > > > Just curious

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
> On 2012-05-22 18:13:21, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java, > > line 74 > > > > > > Just curious

Securing Oauth 1 secrets

2012-05-22 Thread Michael Matthews
I'm adding an OAuth 1.0 OAuthStore implementation to our OpenSocial container so that gadgets can invoke services secured by OAuth 1. I created a custom implementation of org.apache.shindig.gadgets.oauth.OAuthStore and have it persisting all OAuth 1 data to a relational database. I'd like to make

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Xiao Feng Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/ --- (Updated 2012-05-22 18:20:43.399280) Review request for shindig, Ryan Baxter, Da

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Xiao Feng Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/ --- (Updated 2012-05-22 18:18:13.402322) Review request for shindig, Ryan Baxter, Da

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4268/#review8037 --- Ship it! +1 Looks good for first drop. We can push it to get more han

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Xiao Feng Yu
> On 2012-05-22 12:20:21, Stanton Sievers wrote: > > While the sample gadget that you added does use the new APIs it is not > > obvious from the interaction with the gadget that they are being used. Are > > the images on picasa themselves not protected? Only the feed is? A > > compelling de

Re: Review Request: pass User-Agent header on makeRequest

2012-05-22 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5162/#review8035 --- Ship it! Committed revision 1341484. Please close this review. - St

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4268/ --- (Updated 2012-05-22 13:55:37.337786) Review request for shindig, Henry Saputra,

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
> On 2012-05-22 13:50:25, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/DomainName.java, > > line 52 > > > > > > Not

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4268/#review8033 --- http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/mai

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4268/ --- (Updated 2012-05-22 13:49:24.804113) Review request for shindig, Henry Saputra,

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
> On 2012-05-22 13:24:16, Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/DomainName.java, > > line 52 > > > > > > We should pr

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4268/#review8031 --- http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/mai

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4268/ --- (Updated 2012-05-22 12:55:46.675824) Review request for shindig, Henry Saputra,

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
> On 2012-05-21 19:24:30, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GlobalId.java, > > line 144 > > > > > > Small n

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/#review8029 --- While the sample gadget that you added does use the new APIs it is not

Re: Review Request: Base Implementation for Groups

2012-05-22 Thread Mike May
> On 2012-05-21 20:34:39, BrianLillie wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/LocalId.java, > > line 41 > > > > > > Any need to va

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Xiao Feng Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/ --- (Updated 2012-05-22 08:51:49.168988) Review request for shindig, Ryan Baxter, Da

Re: Review Request: Add OAuth support in content proxy to access protected resources with content

2012-05-22 Thread Xiao Feng Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5112/ --- (Updated 2012-05-22 08:47:38.65) Review request for shindig, Ryan Baxter, Da