Thanks guys!
Paul, should I delete the tag and regenerate it? Or should I port the fix
to the tag and rebuild the artifacts?
-Ryan
From: Stanton Sievers/Westford/IBM@Lotus
To: dev@shindig.apache.org,
Date: 06/07/2012 07:08 PM
Subject:Re: Issue with container and security t
Committed revision 1347826.
I built and sanity checked that a handful of sample gadgets still rendered
in the sample common container page.
Ryan, let me know if there's anything you need to get the beta2 re-spin
going.
Thanks,
-Stanton
From: Henry Saputra
To: dev@shindig.apache.org,
Review for SHINDIG-1791
http://codereview.appspot.com/6305066/
Sweet =)
Yeah Ryan needs to create new RC for beta2 release (sorry Ryan)
- Henry
On Thu, Jun 7, 2012 at 2:11 PM, Stanton Sievers wrote:
> Not if I assign it to me first! :)
>
> Doug confirmed the fix works for him. I can deliver it, but then will
> Ryan need to re-spin beta2? We only tag for
Not if I assign it to me first! :)
Doug confirmed the fix works for him. I can deliver it, but then will
Ryan need to re-spin beta2? We only tag for beta2, not branch, right?
Thanks,
-Stanton
From: Henry Saputra
To: dev@shindig.apache.org,
Date: 06/07/2012 16:55
Subject:Re
Thanks Stanton, can I assign this to you?
- Henry
On Thu, Jun 7, 2012 at 1:45 PM, Stanton Sievers wrote:
> I updated Doug's JIRA [1] with what I think the code needs to be changed
> to. I haven't tested it, however.
>
> [1] https://issues.apache.org/jira/browse/SHINDIG-1794
>
> Thanks,
> -Stant
I updated Doug's JIRA [1] with what I think the code needs to be changed
to. I haven't tested it, however.
[1] https://issues.apache.org/jira/browse/SHINDIG-1794
Thanks,
-Stanton
From: Henry Saputra
To: dev@shindig.apache.org,
Date: 06/07/2012 16:31
Subject:Re: Issue with c
Thanks Doug, looks like this check is not right !scriptEls && i <
scriptEls.length so the container always set to default
- Henry
On Thu, Jun 7, 2012 at 12:37 PM, daviesd wrote:
> The for loop in init.js is broken.
>
> If I change
>
> for(var i = 0; !scriptEls && i < scriptEls.length; i++)
-1 until SHINDIG-1794 is fixed (if deemed necessary for release).
doug
On 6/6/12 9:39 AM, "Ryan J Baxter" wrote:
> Hi All,
>
> I finished the 2.5.0-beta2 release last night, here is all the info.
>
> We solved 52 issues:
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?mode=hide&r
The for loop in init.js is broken.
If I change
for(var i = 0; !scriptEls && i < scriptEls.length; i++) {
to
for(var i = 0; i < scriptEls.length; i++) {
It fixes the issue and the right container is used.
doug
On 6/7/12 3:15 PM, "Stanton Sievers" wrote:
> Sorry for the spam, on
Ryan,
Yes, it would make sense for our use case, but I can also see how it doesn't
fit in with the spec exactly. I'm not 100% sure what an Object-Id is
suppose to be, but I guess we could fall borderline into that category as
well.
In our case specifying @institution tells the shindig apis to us
Sorry for the spam, one other thought. Do you have any other script tags
that match this regex in your page, Doug? We might be finding the wrong
one that doesn't have the container query param on it.
Thanks,
-Stanton
From: Stanton Sievers/Westford/IBM
To: dev@shindig.apache.org,
Date
Please see my follow up email comparing beta1 to beta2 with pure shindig
(none of my modifications). The problem is demonstrated there (although it
could be user error too).
doug
On 6/7/12 3:12 PM, "Stanton Sievers" wrote:
> Henry,
>
> I think it does match. I executed the folllowing in my f
Henry,
I think it does match. I executed the folllowing in my firebug console
and it returned true:
/.*gadgets\/js\/.*container.*[.]js.*[?&]c=1(&|$).*/.test("
http://ocwms.worldkat.qa.oclc.org/opensocial/gadgets/js/oclccontainer:userprefsui:rpc.js?nocache=1&c=1&debug=1&container=oclc
");
Doug,
On 6/6/12 1:43 PM, "Dan Dumont" wrote:
>https://github.com/kriskowal/q
>I think this will make coding async operations in shindig MUCH easier to
>do, read, review, troubleshoot , etc...
>I'd like to target some spec changes (for 3.0 or later) as well to
>specify
>that some arguments to apis will
Actually its maybe in the init.js function initializeGlobalVars()
Looks like the URL
http://ocwms.worldkat.qa.oclc.org/opensocial/gadgets/js/oclccontainer:userpr
efsui:rpc.js?nocache=1&c=1&debug=1&container=oclc does not contain the
expected pattern
/.*gadgets\/js\/.*container.*[.]js.*[?&]c=1(&|$
Henry/All,
I retested with snapshots of beta1 and beta2 (ruling out all my extensions
in our container).
There is definitely a difference in behavior. In beta1 buildUri gets the
container name right (oclc).
String container = context.getContainer();
In beta2 in gets it wrong (default).
Here a
Seems like the iframe URL returned from the metadata call gets the
wrong container.
Doug, could you debug in the DefaultIframeUriManager.buildUri what is
the container returned?
- Henry
On Thu, Jun 7, 2012 at 9:30 AM, daviesd wrote:
> In beta1 I use to see the following flow.
>
> Request the ja
Reviewers: dev_shindig.apache.org, clakre_gmail.com,
Message:
Review for SHINDIG-1791
Description:
CR for SHINDIG-1791
BasicOAuth2Store setToken converts the gadget URI and serviceName into a
processed name for shared clients. This processed name is then passed
to getToken. The change is to p
In beta1 I use to see the following flow.
Request the javascript using container=oclc
http://ocwms.worldkat.qa.oclc.org/opensocial/gadgets/js/oclccontainer:userpr
efsui:rpc.js?nocache=1&c=1&debug=1&container=oclc
The iframe request would then look as follows
http://ocwms.worldkat.qa.oclc.org/op
NP Doug we will work through them as you find them :) Thanks for testing.
-Ryan
From: daviesd
To: ,
Date: 06/07/2012 09:27 AM
Subject:Re: [VOTE] Release Apache Shindig version 2.5.0-beta2
Ryan,
I'd love to +1 but I'm still having some integration issues (I'm composing
a
Ryan,
I'd love to +1 but I'm still having some integration issues (I'm composing a
separate email for the GroupId issue). I'm also getting the dreaded "HTTP
Status 401 - Malformed security token %st%Invalid security token %st% " I
think when a gadget makes a request to the container (Flash gadget
+1
checked basic license issues
jars work.
checksums are good.
Great work Ryan!
On Wed, Jun 6, 2012 at 6:39 AM, Ryan J Baxter wrote:
> Hi All,
>
> I finished the 2.5.0-beta2 release last night, here is all the info.
>
> We solved 52 issues:
>
> https://issues.apache.org/jira/secure/IssueNaviga
23 matches
Mail list logo
