Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread DouglasLDavies
http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java File java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java (right): http://codereview.appspot.com/6305079/diff/6001/java/socia

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread rbaxter85
Updated comments http://codereview.appspot.com/6305079/

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread rbaxter85
http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java File java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java (right): http://codereview.appspot.com/6305079/diff/6001/java/socia

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread sieverssj
LGTM. http://codereview.appspot.com/6305079/

OAuth2 token expiration and issue times broken

2012-06-11 Thread daviesd
The fix for SHINDIG-1732 introduces a bug with the oauth2 token expires and issue times (or at least a documentation change). The time stored in OAuth2Token use to be in seconds (and is documented that way). Now it¹s storing them in milliseconds in TokenAuthorizationResponseHandler. This causes

Shindig snapshots

2012-06-11 Thread daviesd
I¹m having issues again getting the latest maven artifacts (I¹ve been using beta1 for a while now). This is the repository I¹m using (for both beta and snapshot) https://repository.apache.org/content/groups/public/org/apache/shindig However the snapshots don¹t seem to have been updated since the

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread TheMistyMay
Other than the null comment...LGTM Applied patch and ran tests, all successful. Ship it! http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java File java/social-api/src/main/java/org/apache/shindig/social/opensocial/s

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread daviesd
Not to get greedy about all the stuff I need for beta2, but... :) Ryan, is this going in before you do the beta2 rebuild? Thanks for all your help on getting these things resolved so quickly. I'm still testing this fix, but having maven repo issues this morning, and I was trying to apply the fix

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread rbaxter85
Updated based on Doug's suggestions. http://codereview.appspot.com/6305079/

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread DouglasLDavies
http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java File java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java (right): http://codereview.appspot.com/6305079/diff/6001/java/social-api/sr

Fwd: reviews.apache.org returning 503

2012-06-11 Thread Ryan Baxter
FYI -- Forwarded message -- From: Ryan Baxter Date: Sun, Jun 10, 2012 at 11:19 AM Subject: Re: reviews.apache.org returning 503 To: ga...@16degrees.com.au Cc: Greg Stein , infrastruct...@apache.org Thanks for the update Gav. On Sun, Jun 10, 2012 at 1:42 AM, Gavin McDonald wrot

AUTO: Kris is out of the office, returning 06/12/12

2012-06-11 Thread Kris Vishwanathan
I am out of the office until 06/12/2012. I will be on vacation returning 06/12/12, Please contact my manager Steve Baber in case of an urgent issues. Note: This is an automated response to your message "Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)" sent on 0