Reviewers: Stanton, dev_shindig.apache.org,
Description:
Allow fatal errors to be reported to waiting callbacks.
Allow callbacks to indicate they aren't pushy, and don't want to trigger
an immediate refresh.
Allow containers to ask the refresh mechanism to call back again in x
seconds when there
On 2012/06/13 17:53:22, Stanton wrote:
LGTM
Brian do you have a link to the JIRA?
http://codereview.appspot.com/6306074/
+1
http://codereview.appspot.com/6306074/
Nice patch. I had overriden
AnonymousAuthenticationHandler.getSecurityTokenFromRequest to accomplish the
same thing. Now I can back that out.
doug
On 6/13/12 1:53 PM, "siever...@gmail.com" wrote:
> LGTM
>
> http://codereview.appspot.com/6306074/
>
LGTM
http://codereview.appspot.com/6306074/
Updated patch to use Anonymous Security Token
http://codereview.appspot.com/6306074/
+1 (non-binding)
On 6/12/12 10:41 PM, "Ryan J Baxter" wrote:
> I discarded the original staging repo, took in the new fixes, and
> regenerated beta2.
>
> The new staging repo is here:
> https://repository.apache.org/content/repositories/orgapacheshindig-232/
>
> Also here is the new list of i
On 2012/06/13 13:40:57, rbaxter85 wrote:
On 2012/06/13 12:49:11, btlillie wrote:
LGTM. Out of curiosity, are there no unit tests for this code?
Brian could you add the dev list as well?
There was nothing that specifically tests whether a token was present or
not, or was added. Without a
LGTM
http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js
File features/src/main/javascript/features/caja/taming.js (right):
http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js#newcode128
features/src/mai
Changed variable name
http://codereview.appspot.com/6305079/
On 2012/06/12 13:34:52, rbaxter85 wrote:
Changed variable name
Committed
http://codereview.appspot.com/6305079/
11 matches
Mail list logo
