http://codereview.appspot.com/6306074/diff/7002/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
(right):
http://codereview.appspot.com/6306074/diff/7002/java/gadge
http://codereview.appspot.com/6306074/diff/7002/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
(right):
http://codereview.appspot.com/6306074/diff/7002/java/gadge
LGTM. As a followup to this review I may look into how we can better
generate SecurityToken token objects that align with the injected codec.
More to come on that later.
http://codereview.appspot.com/6306074/
+1
Smoke tested the sample common container from the generated war and things
look good.
-Stanton
From: Paul Lindner
To: dev@shindig.apache.org,
Date: 06/14/2012 21:45
Subject:Re: [VOTE] Release Apache Shindig version 2.5.0-beta2
Sent by:pmlind...@gmail.com
Looks
Looks good from my vantage point too!
+1.
On Thu, Jun 14, 2012 at 4:25 PM, Ryan J Baxter wrote:
> +1 from me too.
>
> -Ryan
>
>
>
>
> From: Henry Saputra
> To: dev@shindig.apache.org,
> Date: 06/14/2012 02:03 PM
> Subject:Re: [VOTE] Release Apache Shindig version 2.5.0-beta2
>
On 2012/06/14 19:11:14, btlillie wrote:
Switching back to BlobCrypterSecurityToken from AnonymousSecurityToken
LGTM, but then again I said that last time too :)
http://codereview.appspot.com/6306074/
+1 from me too.
-Ryan
From: Henry Saputra
To: dev@shindig.apache.org,
Date: 06/14/2012 02:03 PM
Subject:Re: [VOTE] Release Apache Shindig version 2.5.0-beta2
Signatures are good
Replace generated jars in the demo server and sanity run looks good.
+1
- Henry
On Tue, Jun
Switching back to BlobCrypterSecurityToken from AnonymousSecurityToken
http://codereview.appspot.com/6306074/
Doug,
We are running with secure tokens and though I tried it and it appeared to
be working, it couldn't work and its failing for me now ..
I'll post a revision shortly for review
brian
From: daviesd
To: ,
Date: 06/14/2012 12:04 PM
Subject:Re: Pass token on listMethods to e
Doug you probably want to murder us by this pointsorry about that :)
+1 for you verifying all this stuff.
We are working on a fix now, and I have reverted the change. We should
have an updated patch soon.
-Ryan
From: daviesd
To: ,
Date: 06/14/2012 01:05 PM
Subject:Re
Signatures are good
Replace generated jars in the demo server and sanity run looks good.
+1
- Henry
On Tue, Jun 12, 2012 at 7:41 PM, Ryan J Baxter wrote:
> I discarded the original staging repo, took in the new fixes, and
> regenerated beta2.
>
> The new staging repo is here:
> https://reposit
Ya, I tried this with shindig trunk (and not my stuff). If you set
shindig.allowUnauthenticated=false
In shindig.properties and
"gadgets.securityTokenType" : "secure",
"gadgets.securityTokenKey" : "NotGonnaShowYouMyKey=",
In container.js
It blows up. I think this change needs to be reworked.
I'm a little bit confused on this. I'm trying it and I'm getting an
exception (it could be because I provide my own
BlobCrypterSecurityTokenCodec and maybe I have some work to do here).
When DefaultServiceFetcher creates an AnonymousSecurityToken and then calls
encodeToken, won't that throw an ex
On 2012/06/13 21:16:26, henry.saputra wrote:
+1
Committed revision 1350234
http://codereview.appspot.com/6306074/
14 matches
Mail list logo
