Re: OpenSocial Space extension

2012-07-27 Thread Ryan Baxter
Evgeny thanks for continuing to drive this. I would not mind seeing it in Shindig. Are the changes isolated enough that it will not effect any of the other features? (I did not look at the patch yet but this would be my main concern.) On Friday, July 27, 2012 8:47:50 AM UTC-4, Evgeny Bogdano

Re: Review Request: Data pipelining request not working when container in SSL mode

2012-07-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6084/#review9549 --- Ship it! Committed r1366484. Please close the review and the JIRA -

Re: [VOTE] Release Apache Shindig version 2.5.0-beta3

2012-07-27 Thread Henry Saputra
gpg signature validation looks good. jars running well in sample server web app. +1 - Henry On Wed, Jul 25, 2012 at 7:56 PM, Ryan Baxter wrote: > Hi, > > We solved 19 issues: > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+SHINDIG+AND+fixVersion+%3D+

Re: Getting build errors building sshindig-project-2.5.0-beta3

2012-07-27 Thread Stanton Sievers
Excellent. I committed the patch. Thanks! From: Jasha Joachimsthal To: dev@shindig.apache.org, Date: 07/27/2012 14:14 Subject:Re: Getting build errors building sshindig-project-2.5.0-beta3 Sent by:jas...@gmail.com In the gadgets module Maven adds extra source fold

Re: Getting build errors building sshindig-project-2.5.0-beta3

2012-07-27 Thread Jasha Joachimsthal
In the gadgets module Maven adds extra source folders based on the jdk version. There are profiles for Java 5 and Java 6, but not for other versions. I added a patch for trunk to https://issues.apache.org/jira/browse/SHINDIG-1829 that activates the java6 profile for jdk 1.6 and up (instead of just

OpenSocial Space extension

2012-07-27 Thread Evgeny Bogdanov
Hi all, OpenSocial 2.5 is about to come out, the same is true for Shindig 2.5. The Space extension is on the todo list for OpenSocial 3.0. Before, there were patches for shindig 2.0 and OS2.0. Lately, I redesigned the Space extension with the emphasis on IRI support and backward compatibility. Th

Re: Getting build errors building sshindig-project-2.5.0-beta3

2012-07-27 Thread Stanton Sievers
Hi Bob, This is most likely an issue with the version of Java you are using to build with. I'm going to take a stab at it and say you are using Java 7. Is that right? There are issues with Java 7, so please try to build with Java 6 when you can. Thanks, -Stanton From: Robert Brehm To:

Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp

2012-07-27 Thread Ryan Baxter
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote: > > Ship It! > > Ryan Baxter wrote: > Committed revision 1366425 > > Ryan Baxter wrote: > Mike can you attach the patch to the JIRA? I should have checked this > first before checking it in. > > Mike May wrote: > Attached! My bad

Getting build errors building sshindig-project-2.5.0-beta3

2012-07-27 Thread Robert Brehm
Hi List, I am buiding shindig-project-2.5.0-beta3 on a Windows 7 64 bit machine. I am following the instructions in https://cwiki.apache.org/confluence/display/SHINDIG/Setting+Up+An+Eclipse+Development+Environment+For+Shindig+%28Java%29. Step 55. The result is as follows: [INFO] ---

Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp

2012-07-27 Thread Mike May
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote: > > Ship It! > > Ryan Baxter wrote: > Committed revision 1366425 > > Ryan Baxter wrote: > Mike can you attach the patch to the JIRA? I should have checked this > first before checking it in. Attached! My bad, thought I had already at

Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp

2012-07-27 Thread Ryan Baxter
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote: > > Ship It! > > Ryan Baxter wrote: > Committed revision 1366425 Mike can you attach the patch to the JIRA? I should have checked this first before checking it in. - Ryan --- Thi

Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp

2012-07-27 Thread Ryan Baxter
> On July 26, 2012, 11:15 p.m., Ryan Baxter wrote: > > Ship It! Committed revision 1366425 - Ryan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6155/#review9522

Re: [VOTE] Release Apache Shindig version 2.5.0-beta3

2012-07-27 Thread Ryan Baxter
Thanks Doug! 1799 was missing the beta3 tag so I added it. On Fri, Jul 27, 2012 at 11:19 AM, daviesd wrote: > +1 (non-binding) > > The two issue I needed (SHINDIG-1799 & SHINDIG-1812) are working for me. > BTW... Not sure why 1799 doesn't show up in your fixed list, but I show it > as being fix

Re: [VOTE] Release Apache Shindig version 2.5.0-beta3

2012-07-27 Thread daviesd
+1 (non-binding) The two issue I needed (SHINDIG-1799 & SHINDIG-1812) are working for me. BTW... Not sure why 1799 doesn't show up in your fixed list, but I show it as being fixed after beta2. doug On 7/25/12 10:56 PM, "Ryan Baxter" wrote: > Hi, > > We solved 19 issues: > https://issues.apac

Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp

2012-07-27 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6155/#review9532 --- Ship it! Ship It! - Dan Dumont On July 26, 2012, 5:26 p.m., Mike M

Re: Review Request: Adding IDs to form elements in login.jsp and authorize.jsp

2012-07-27 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6155/#review9530 --- Ship it! Ship It! - Stanton Sievers On July 26, 2012, 5:26 p.m., M