Re: Review Request: Leaky abstraction wrt BeanJsonConverter.

2012-09-25 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7266/#review11916 --- Ship it! Committed revision 1390234. Please close this review. - S

Re: Review Request: Leaky abstraction wrt BeanJsonConverter.

2012-09-25 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7266/#review11915 --- Ship it! Ship It! - Ryan Baxter On Sept. 25, 2012, 6:30 p.m., Jan

Re: enabling default features for all gadgets

2012-09-25 Thread Dan Dumont
There's also a property in shindig.properties that lists the core features everything must have (which is currently core and rpc) On Tue, Sep 25, 2012 at 2:46 PM, Henry Saputra wrote: > HI Christian, > > You can either have custom DefaultGadgetSpecFactory.parse() and > decorate the ModulePrefs el

Re: enabling default features for all gadgets

2012-09-25 Thread Henry Saputra
HI Christian, You can either have custom DefaultGadgetSpecFactory.parse() and decorate the ModulePrefs element with your features or have custom Processor.process() to add default or additional feature there. Or you can have custom rewriter early in the flow and add the required features via call

enabling default features for all gadgets

2012-09-25 Thread Christian Fischer
Hi all, i'm using shindig (inside Apache RAVE) for my master-thesis and need to enable a default feature for all gadgets even the gadgets doesn't require this feature. In other words: i must inject a reference to a javascript file into each gadget. What is the best way to acquire this goal w

Re: Review Request: Leaky abstraction wrt BeanJsonConverter.

2012-09-25 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7266/#review11902 --- Ship it! Well thats a good catch =) +1 - Henry Saputra On Sept.

Review Request: Leaky abstraction wrt BeanJsonConverter.

2012-09-25 Thread Jan Willem Janssen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7266/ --- Review request for shindig. Description --- See https://issues.apache.org/j

Re: Review Request: Code Review for JIRA 1801, shared tokens should share accessors

2012-09-25 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/ --- (Updated Sept. 25, 2012, 4:40 p.m.) Review request for shindig, Stanton Sievers