----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9773/ -----------------------------------------------------------
(Updated Jan. 8, 2014, 1:37 p.m.) Review request for shindig. Changes ------- We created a new patch that has a substantially improved architecture separating APL-licensed code at Shindig side from GPL-licensed code at neo4j side by a Websocket connection, so that no compile dependencies between the two code parts exists. Please note that additional software is necessary to run Shindig with that patch. It is described in the environment field of the issue. Test data to verify the patch can be obtained from dropbox https://dl.dropboxusercontent.com/u/32445341/neo4j.zip Zip file should be extracted to a new folder. Then point the neo4j server to this folder as its database folder. Bugs: Shindig-1911 https://issues.apache.org/jira/browse/Shindig-1911 Repository: shindig Description ------- Review for Shindig-1911 Alternative database backend based on graph database neo4j Any comments welcome. We are committed to further improve this. Diffs (updated) ----- /trunk/java/websocket-backend/LICENSE PRE-CREATION /trunk/java/websocket-backend/NOTICE PRE-CREATION /trunk/java/websocket-backend/README PRE-CREATION /trunk/java/websocket-backend/pom.xml PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION /trunk/pom.xml 1556165 Diff: https://reviews.apache.org/r/9773/diff/ Testing ------- Thanks, René Peinl
