Re: Review Request 33940: Fixed for SHINDIG-1994

2015-05-07 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33940/#review82890 --- Ship it! Ship It! - Ryan Baxter On May 7, 2015, 5:35 p.m., Doug

Re: Review Request 33940: Fixed for SHINDIG-1994

2015-05-07 Thread Doug Davies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33940/ --- (Updated May 7, 2015, 5:35 p.m.) Review request for shindig, Ryan Baxter and St

Re: Review Request 33940: Fixed for SHINDIG-1994

2015-05-07 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33940/#review82826 --- trunk/features/src/main/javascript/features/container.site.gadget/g

Re: getActiveSiteHolder

2015-05-07 Thread Davies,Douglas
I have submitted bug https://issues.apache.org/jira/browse/SHINDIG-1994 and a proposed fix in review https://reviews.apache.org/r/33940 The issue has to do with the new module id stuff and the callback in gadget_site:navigateTo being called before the setModuleId_ method competes. I restru

Review Request 33940: Fixed for SHINDIG-1994

2015-05-07 Thread Doug Davies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33940/ --- Review request for shindig, Ryan Baxter and Stanton Sievers. Bugs: SHINDIG-1994