Re: Pass token on listMethods to enable allowUnauthenticated=false (issue 6306074)

2012-06-14 Thread btlillie
Switching back to BlobCrypterSecurityToken from AnonymousSecurityToken http://codereview.appspot.com/6306074/

Re: Pass token on listMethods to enable allowUnauthenticated=false (issue 6306074)

2012-06-13 Thread btlillie
Updated patch to use Anonymous Security Token http://codereview.appspot.com/6306074/

Re: Pass token on listMethods to enable allowUnauthenticated=false (issue 6306074)

2012-06-13 Thread btlillie
On 2012/06/13 13:40:57, rbaxter85 wrote: On 2012/06/13 12:49:11, btlillie wrote: LGTM. Out of curiosity, are there no unit tests for this code? Brian could you add the dev list as well? There was nothing that specifically tests whether a token was present or not, or was added. Without

Re: BasicOAuth2Store calling getToken with incorrect URI (issue 6305066)

2012-06-07 Thread btlillie
Review for SHINDIG-1791 http://codereview.appspot.com/6305066/

BasicOAuth2Store calling getToken with incorrect URI (issue 6305066)

2012-06-07 Thread btlillie
Reviewers: dev_shindig.apache.org, clakre_gmail.com, Message: Review for SHINDIG-1791 Description: CR for SHINDIG-1791 BasicOAuth2Store setToken converts the gadget URI and serviceName into a processed name for shared clients. This processed name is then passed to getToken. The change is to p