Re: BasicOAuth2Store calling getToken with incorrect URI (issue 6305066)

2012-06-08 Thread sieverssj
Ship it! http://codereview.appspot.com/6305066/

Re: BasicOAuth2Store calling getToken with incorrect URI (issue 6305066)

2012-06-08 Thread sieverssj
Committed revision 1348118. http://codereview.appspot.com/6305066/

Re: BasicOAuth2Store calling getToken with incorrect URI (issue 6305066)

2012-06-08 Thread clakre
On 2012/06/08 11:12:28, Stanton wrote: Ship it! Looks good to me too, Ship it! http://codereview.appspot.com/6305066/

Re: BasicOAuth2Store calling getToken with incorrect URI (issue 6305066)

2012-06-07 Thread btlillie
Review for SHINDIG-1791 http://codereview.appspot.com/6305066/

BasicOAuth2Store calling getToken with incorrect URI (issue 6305066)

2012-06-07 Thread btlillie
Reviewers: dev_shindig.apache.org, clakre_gmail.com, Message: Review for SHINDIG-1791 Description: CR for SHINDIG-1791 BasicOAuth2Store setToken converts the gadget URI and serviceName into a processed name for shared clients. This processed name is then passed to getToken. The change is to p