LGTM, nice cleanup. Committing.
On 2010/07/14 15:52:00, gagan.goku wrote:
http://codereview.appspot.com/1798042/diff/7001/7
File
main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
(left):
http://codereview.appspot.com/1798042/diff/7001/7#oldcode72
main/java/org/apache/shindig/
http://codereview.appspot.com/1798042/diff/7001/7
File main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
(left):
http://codereview.appspot.com/1798042/diff/7001/7#oldcode72
main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java:72: }
On 2010/07/14 04:51:10, vikaas.ar
addressing comments
http://codereview.appspot.com/1798042/show
addressing comments
http://codereview.appspot.com/1798042/show
Add some comment to the issue description defining the scope of the
change.
http://codereview.appspot.com/1798042/diff/7001/7
File main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
(left):
http://codereview.appspot.com/1798042/diff/7001/7#oldcode72
main/java/org/apache/shindig/
fixing bad things
http://codereview.appspot.com/1798042/show
Reviewers: johnfargo, zhoresh, cool-shindig-committers_googlegroups.com,
shindig.remailer_gmail.com, dev-remailer_shindig.apache.org,
Please review this at http://codereview.appspot.com/1798042/show
Affected files:
main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
main/j
