Re: Cleaning up javascript with Closure Linter

2010-09-14 Thread Paul Lindner
Okay, big cleanup patch landed. If you need to merge your patch you might want to run things through fixjsstyle script to harmonize. On Fri, Sep 10, 2010 at 5:10 AM, Gagandeep Singh wrote: > The patch looks good. A script to split all the files into multiple > codereviews could be helpful here.

Re: Cleaning up javascript with Closure Linter

2010-09-10 Thread Gagandeep Singh
The patch looks good. A script to split all the files into multiple codereviews could be helpful here. Thanks Gagan On Fri, Sep 10, 2010 at 4:33 PM, Paul Lindner wrote: > A while back I had started cleaning up the javascript code base to use > improved JsDoc annotations. > > Recently the Clo

Re: Cleaning up javascript with Closure Linter

2010-09-10 Thread Pablo GraƱa
There is also jslint, that can be run from a maven plugin. It does not modifies the code, just reports on practicese, as checkstyle or findbugs. On Fri, Sep 10, 2010 at 8:03 AM, Paul Lindner wrote: > A while back I had started cleaning up the javascript code base to use > improved JsDoc annotati

Cleaning up javascript with Closure Linter

2010-09-10 Thread Paul Lindner
A while back I had started cleaning up the javascript code base to use improved JsDoc annotations. Recently the Closure Linter was released: http://code.google.com/closure/utilities/ I'd like to propose that we run all of the javascript code through fixjsstyle. A patch of this size causes coder