Re: Continued improvement to exception handling code (issue207059)

On Thu, Feb 11, 2010 at 2:57 AM, wrote: > > http://codereview.appspot.com/207059/diff/1/14 > File > > java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java > (right): > > http://codereview.appspot.com/207059/diff/1/14#newcode134 > > java/gadgets/src/main/java/org/apache/s

Re: Continued improvement to exception handling code (issue207059)

IMO we should return 500 when there's an Exception within the fetcher, but 504 when translating this to Shindig-emitted status codes, such as here. Could you help clean this up in your already-open BasicHttpFetcher cleanup CL? Thanks, John On Wed, Feb 10, 2010 at 2:17 PM, wrote: > LGTM > > > >

Continued improvement to exception handling code (issue207059)

Reviewers: shindig.remailer_gmail.com, Description: I'm committing this code early since we need it in fairly short order and it seems quite low-risk: familiar design pattern, no semantic difference in any behavior, just cleanup. Still, the line count is somewhat higher than I'm comfortable commi