Re: GroupId

2012-06-10 Thread Ryan J Baxter
Doug here is the review and the JIRA. http://codereview.appspot.com/6305079/ https://issues.apache.org/jira/browse/SHINDIG-1796 -Ryan From: Ryan J Baxter/Westford/IBM To: dev@shindig.apache.org, Date: 06/09/2012 07:36 PM Subject:Re: GroupId Doug I hope to get a chance

Re: GroupId

2012-06-09 Thread Ryan J Baxter
Doug I hope to get a chance to look at a possible solution tomorrow. -Ryan From: daviesd To: , Date: 06/09/2012 12:49 AM Subject:Re: GroupId I had not opened one. I was waiting for Ryan's response to my follow-up. doug On 6/8/12 9:16 PM, "Henry Saputra"

Re: GroupId

2012-06-08 Thread daviesd
I had not opened one. I was waiting for Ryan's response to my follow-up. doug On 6/8/12 9:16 PM, "Henry Saputra" wrote: > Hi Doug, do you have a JIRA opened for this issue? > > - Henry > > On Wed, Jun 6, 2012 at 9:52 AM, daviesd wrote: >> Some chan

Re: GroupId

2012-06-08 Thread Henry Saputra
Hi Doug, do you have a JIRA opened for this issue? - Henry On Wed, Jun 6, 2012 at 9:52 AM, daviesd wrote: > Some changes were made to GroupId between 2.5-beta1 and 2.5-beta2 that are > affecting me. > > GroupId.Type changed from this > >   all, friends, self, deleted, gr

Re: GroupId

2012-06-07 Thread daviesd
; > Doug are you basically extending GroupId with your own custom "@" id? We > didn't consider this case, we basically support the @ ids from the spec > and then object id, so it makes sense that if you pass another id we throw > that exception. I think we might have to

Re: GroupId

2012-06-06 Thread Ryan J Baxter
Yeah we did a lot of work around Groups to actually support them in Shindig. Along the way we found that the Group Id implementation didn't exactly follow the spec. Doug are you basically extending GroupId with your own custom "@" id? We didn't consider this case, we b

Re: GroupId

2012-06-06 Thread Henry Saputra
The change was part of the commits for SHINDIG-1780. Ryan could probably help with this. - Henry On Wed, Jun 6, 2012 at 9:52 AM, daviesd wrote: > Some changes were made to GroupId between 2.5-beta1 and 2.5-beta2 that are > affecting me. > > GroupId.Type changed from this > &

GroupId

2012-06-06 Thread daviesd
Some changes were made to GroupId between 2.5-beta1 and 2.5-beta2 that are affecting me. GroupId.Type changed from this all, friends, self, deleted, groupId; To this objectId(0), self(1), friends(2), all(3); We had extended AppDataService to support a groupId of @institution (something