LGTM, committed.
http://codereview.appspot.com/217102/show
Add test for BOM char
http://codereview.appspot.com/217102/show
Attached is the patch with new test. The codereview service keep on giving
me 500 error.
I will put it there when it will be more stable.
-Ziv
On Wed, Feb 24, 2010 at 9:53 AM, Ziv Horesh wrote:
> The actual BOM char is being trimmed by HttpResponse.getResponseAsString
> function.
> We can also
The actual BOM char is being trimmed by HttpResponse.getResponseAsString
function.
We can also trim the BOM string there.
Since we are not sure if it is standard, I would vote to handle it only in
he cases we really want to, i.e. trim it just before XML parsing in
SpecFactory.
I will attach next a
This code looks fine. Have you tried w/ the actual BOM bytes as well? We
may as well be sure to handle both.
Also... has anyone seen this particular behavior before re: BOMs
(escaped BOM chars)? It's not clear to me if this is standard behavior.
I don't see any particular problem supporting it in
