Re: Inline gadget rendering as a feature

2010-11-07 Thread ๏̯͡๏ Jasvir Nagra
Thanks Kai - I'll have a look at this tomorrow. On Sun, Nov 7, 2010 at 5:42 PM, Kai Feng Zhang wrote: > I uploaded patch here: http://codereview.appspot.com/2927041/ , for code > review. Thanks. > > > On Wed, Nov 3, 2010 at 5:00 PM, Kai Feng Zhang wrote: > > > Hi Jasvir, > > > > Thank you very

Re: Inline gadget rendering as a feature

2010-11-07 Thread Kai Feng Zhang
I uploaded patch here: http://codereview.appspot.com/2927041/ , for code review. Thanks. On Wed, Nov 3, 2010 at 5:00 PM, Kai Feng Zhang wrote: > Hi Jasvir, > > Thank you very much for the very helpful ways to care about the security > concerns. Please see my comments in blue below. > > Best Reg

Re: Inline gadget rendering as a feature

2010-11-03 Thread Kai Feng Zhang
Hi Jasvir, Thank you very much for the very helpful ways to care about the security concerns. Please see my comments in blue below. Best Regards, Kevin, Zhang Kai Feng IBM Project Vulcan Development IBM China Software Development Lab 2010/11/3 ๏̯͡๏ Jasvir Nagra > Sorry that was perhaps less

Re: Inline gadget rendering as a feature

2010-11-03 Thread Kai Feng Zhang
Hi Jasvir, Thank you for this quick response. For your comments: but from exposing the opensocial and other gadget apis to inlined code. > These apis modify the javascript prototypes and other DOM objects on > behalf > of gadgets and are a means by which otherwise isolated gadgets may > interfer

Re: Inline gadget rendering as a feature

2010-11-02 Thread ๏̯͡๏ Jasvir Nagra
Sorry that was perhaps less than helpful. I looked over the thread you referenced and I think a few clarifications are needed. I realized there is a mis-interpretation that Caja is primarily aimed at "addressing malware and security concerns". The point is that the accidental problems that you m

Re: Inline gadget rendering as a feature

2010-11-02 Thread ๏̯͡๏ Jasvir Nagra
This is just one of the many problems with inlining two or more gadgets gets you. The others include but aren't limited to: * css styles defined in one gadget will apply on other gadgets with elements, classes, ids or other selectors that match * javascript functions and globals between gadgets t

Re: Inline gadget rendering as a feature

2010-11-02 Thread Kai Feng Zhang
The first problem inline gadget rendering needs to solve is about namespacing conflict. Since some gadget declare a unique identifier for some element in dom, such as , if this gadget is rendered with inline multiple times on same page, it's a problem of element id conflict. As our former impleme

Inline gadget rendering as a feature

2010-11-02 Thread Kai Feng Zhang
Hi, We originally posted inlining work directly into the existing container shindig-container/server side components... see https://issues.apache.org/jira/browse/SHINDIG-1402 After reviewing some of these changes and learning more about the features, we've stepped back and refactored those change