Re: Issue 2136044: Adding static files back to shindig jar

Reverting this change. Lets find a way to get the important files under content/ directory moved to under features/ directory. Thanks for the review. Gagan On Tue, Sep 14, 2010 at 12:58 AM, Gagandeep singh wrote: > Or are you suggesting keeping content/ directory as is, but adding it to > feat

Re: Issue 2136044: Adding static files back to shindig jar

Or are you suggesting keeping content/ directory as is, but adding it to features/pom.xml as resources so gadgets.jar still remains lightweight and features.jar gets these files ? On Sat, Sep 11, 2010 at 11:35 AM, Gagandeep singh wrote: > Hi Paul > > I don't have much idea about the container / g

Re: Issue 2136044: Adding static files back to shindig jar

Hi Paul I don't have much idea about the container / gadget related javascript and html files. Could you point me to some documentation / commits that can help me get more idea. Did you mean something like: 1) remove the files content/container/cookiebaseduserprefstore.js and other similar files

Re: Issue 2136044: Adding static files back to shindig jar

One could create a content jar. however I'd like to see container specific javascript migrated to the features directory. We already did that for the old shindig container, the other bits would make sense to move there as well. On Thu, Sep 9, 2010 at 12:31 PM, Gagandeep singh wrote: > Hi Paul

Re: Issue 2136044: Adding static files back to shindig jar

Hi Paul After some investigation, it seems we do use more files. It seems cookiebaseduserprefstore.js is served out as well, along with some other files like gadgets.js etc. Seeing that these are getting used, it is okay to add another jar file, say shindig-content.jar (see 2142045

Re: Issue 2136044: Adding static files back to shindig jar

I added that one file back to the the shindig-gadget jar. Let us know if that helps. On Sat, Sep 4, 2010 at 9:49 AM, Gagandeep singh wrote: > We have a test that fails because its not able to find > container/rpc_relay.html. Not sure if any other files are being actively > used as well. > > > On

Re: Issue 2136044: Adding static files back to shindig jar

We have a test that fails because its not able to find container/rpc_relay.html. Not sure if any other files are being actively used as well. On Sat, Sep 4, 2010 at 9:11 PM, Gagandeep singh wrote: > Sorry for the short and confusing mail. I am not sure whether static files > should be included in

Re: Issue 2136044: Adding static files back to shindig jar

Which files are needed? The content directory has been getting large and it was being incorporated into the gadgets jar and the server war. On Sep 4, 2010 8:42 AM, "Gagandeep singh" wrote: > Sorry for the short and confusing mail. I am not sure whether static files > should be included in gadget

Re: Issue 2136044: Adding static files back to shindig jar

Sorry for the short and confusing mail. I am not sure whether static files should be included in gadgets.jar or not. I was trying to incorporate shindig head into our system and noticed a failure most likely caused by the removal of static files. If this is not the right change to make, please do

Issue 2136044: Adding static files back to shindig jar

Reviewers: dev@shindig.apache.org, lindner, zhoresh Description: Adding back static files removed in revision 991493. See here:http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/pom.xml?r1=991493&r2=...