Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

>From my chat with Mat, he means that patching in http://codereview.appspot.com/1869052/show fixes the problem. Thanks Gagan On Wed, Aug 4, 2010 at 2:08 PM, Mat Mannion wrote: > Thanks; can confirm my problem is now resolved. > > Mat > > On 3 August 2010 22:01, Gagandeep singh wrote: > > Revie

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

Thanks; can confirm my problem is now resolved. Mat On 3 August 2010 22:01, Gagandeep singh wrote: > Reviewers: dev-remai...@shindig.apache.org > > Message: > Please review. > > As reported by Mat, currently ProxyingVisitor adds null to reservedUri list > for uri's that are not > parsed. It look

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

Reviewers: dev-remai...@shindig.apache.org Message: Please review. As reported by Mat, currently ProxyingVisitor adds null to reservedUri list for uri's that are not parsed. It looks like its done in order to keep reserverUri list and node list in sync. However, this causes a NullPointerException

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

Probably something along these lines would be better: http://codereview.appspot.com/1869052/show ? On Tue, Aug 3, 2010 at 9:04 PM, Gagandeep singh wrote: > Hi Mat > > I think this was done to ensure that the node list and reservedUris list > stay in sy

Re: NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

Hi Mat I think this was done to ensure that the node list and reservedUris list stay in sync. But you raise a good point, its probably better to ignore the failing uri and its corresponding node altogether. On Tue, Aug 3, 2010 at 8:27 PM, Mat Mannion wrote: > Hi all, > > The BBC news gadget > (

NullPointerException in ProxyingVisitor/DefaultProxyUriManager (latest trunk breaking gadget rendering of some important gadgets)

Hi all, The BBC news gadget (http://bbcnewsgadget.googlecode.com/svn/trunk/Gadget/bbc_igoogle_ukedition12.xml) includes some rather strange image URLs for stats tracking that have quotes and tildes in the query string, which causes Uri.parse to throw a UriException: org.apache.shindig.common.uri.