On 2012/06/15 15:23:06, DouglasLDavies wrote:
Ya, trying it now on shindig trunk. Test are failing for me with
org.apache.shindig.auth.SecurityTokenException: Invalid security token
canonical:john.doe:test:domain:appUrl:1:default:1339777341
Doug I am not seeing any failures after apply the
http://codereview.appspot.com/6306074/
I am still having issues.
I rebuilt everything with secure tokens enabled, but skipped tests so that
the build would complete. Now the listMethods call succeeds, but then the
metadata call fails with org.apache.shindig.auth.SecurityTokenException:
Invalid security token
Ryan,
I think we need to rollback the change for now until we got the right fix.
- Henry
On Fri, Jun 15, 2012 at 9:34 AM, daviesd davi...@oclc.org wrote:
I am still having issues.
I rebuilt everything with secure tokens enabled, but skipped tests so that
the build would complete. Now the
to enable
allowUnauthenticated=false (issue 6306074)
Ryan,
I think we need to rollback the change for now until we got the right fix.
- Henry
On Fri, Jun 15, 2012 at 9:34 AM, daviesd davi...@oclc.org wrote:
I am still having issues.
I rebuilt everything with secure tokens enabled, but skipped
: dev@shindig.apache.org
Date: 06/15/2012 01:07 PM
Subject: Re: Pass token on listMethods to enable
allowUnauthenticated=false (issue 6306074)
Ryan,
I think we need to rollback the change for now until we got the right fix.
- Henry
On Fri, Jun 15, 2012 at 9:34 AM, daviesd davi
Guys, I apologize for the confusion.
Ok, tested in my container. There needs to be one more fix.
The container needs to be passed into retrieveServices and used instead of
default. We define our own container in addition to default. Not sure why
it doesn¹t find default, but it was throwing an
http://codereview.appspot.com/6306074/diff/7002/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
(right):
On 2012/06/13 21:16:26, henry.saputra wrote:
+1
Committed revision 1350234
http://codereview.appspot.com/6306074/
I'm a little bit confused on this. I'm trying it and I'm getting an
exception (it could be because I provide my own
BlobCrypterSecurityTokenCodec and maybe I have some work to do here).
When DefaultServiceFetcher creates an AnonymousSecurityToken and then calls
encodeToken, won't that throw an
Ya, I tried this with shindig trunk (and not my stuff). If you set
shindig.allowUnauthenticated=false
In shindig.properties and
gadgets.securityTokenType : secure,
gadgets.securityTokenKey : NotGonnaShowYouMyKey=,
In container.js
It blows up. I think this change needs to be reworked. You
: 06/14/2012 01:05 PM
Subject:Re: Pass token on listMethods to enable
allowUnauthenticated=false (issue 6306074)
Ya, I tried this with shindig trunk (and not my stuff). If you set
shindig.allowUnauthenticated=false
In shindig.properties and
gadgets.securityTokenType : secure
:Re: Pass token on listMethods to enable
allowUnauthenticated=false (issue 6306074)
Ya, I tried this with shindig trunk (and not my stuff). If you set
shindig.allowUnauthenticated=false
In shindig.properties and
gadgets.securityTokenType : secure,
gadgets.securityTokenKey
LGTM. As a followup to this review I may look into how we can better
generate SecurityToken token objects that align with the injected codec.
More to come on that later.
http://codereview.appspot.com/6306074/
http://codereview.appspot.com/6306074/diff/7002/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
(right):
http://codereview.appspot.com/6306074/diff/7002/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java
(right):
On 2012/06/13 13:40:57, rbaxter85 wrote:
On 2012/06/13 12:49:11, btlillie wrote:
LGTM. Out of curiosity, are there no unit tests for this code?
Brian could you add the dev list as well?
There was nothing that specifically tests whether a token was present or
not, or was added. Without
Updated patch to use Anonymous Security Token
http://codereview.appspot.com/6306074/
LGTM
http://codereview.appspot.com/6306074/
Nice patch. I had overriden
AnonymousAuthenticationHandler.getSecurityTokenFromRequest to accomplish the
same thing. Now I can back that out.
doug
On 6/13/12 1:53 PM, siever...@gmail.com siever...@gmail.com wrote:
LGTM
http://codereview.appspot.com/6306074/
+1
http://codereview.appspot.com/6306074/
On 2012/06/13 17:53:22, Stanton wrote:
LGTM
Brian do you have a link to the JIRA?
http://codereview.appspot.com/6306074/
22 matches
Mail list logo
