Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/#review3671 --- Ship it! Committed r1211090 - Dan On 2011-12-06 20:21:36, Dan Dumo

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/ --- (Updated 2011-12-06 20:21:36.585266) Review request for shindig, Ryan Baxter, Ja

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/#review3668 --- Ship it! Looks good to me. - Matthew On 2011-12-06 17:54:35, Dan D

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

> On 2011-12-04 18:55:14, Ryan Baxter wrote: > > You might want to test all your feature xml uses changes work when RPC > > arbitration is enabled as well. Turned that on and I don't see any issues running through the test gadgets. - Dan -

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/ --- (Updated 2011-12-06 17:54:35.648638) Review request for shindig, Ryan Baxter, Ja

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

> On 2011-12-06 02:54:06, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 610 > > > > > > This line seems to be returning undefi

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/#review3654 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/#review3631 --- Thanks everyone for the reviews. I'd like an additional review from

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/#review3630 --- LGTM, I went through selection and actions briefly and focus on the op

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/ --- (Updated 2011-12-05 14:19:41.081436) Review request for shindig, Ryan Baxter, Ja

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

> On 2011-12-04 18:55:14, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 262 > > > > > > Rename this method if we are calling i

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/#review3609 --- You might want to test all your feature xml uses changes work when RPC

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

> On 2011-12-02 21:17:46, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js, > > line 845 > > > > > > Instead of doing site.holder_ you

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/#review3603 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/ --- (Updated 2011-12-02 20:40:53.465844) Review request for shindig, Ryan Baxter, Ja

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/ --- (Updated 2011-12-02 20:07:19.352361) Review request for shindig, Ryan Baxter, Ja

Re: Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/ --- (Updated 2011-12-02 19:50:07.319085) Review request for shindig, Ryan Baxter, Ja

Review Request: Actions, selection, and open-views feature issues in a locked domain environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2994/ --- Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and Stanton