Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Henry Saputra
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > Please attach the final patch to the jira entry. - Henry --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/#review1479 --

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/#review1527 --- Ship it! Thanks for the explanation Dan. LGTM. +1 - Henry On 2011-

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Jesse Ciancetta
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 47 > > > > > > Why does the definition registerOn

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Dan Dumont
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 47 > > > > > > Why does the definition registerOn

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-18 Thread Henry Saputra
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 47 > > > > > > Why does the definition registerOn

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-17 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/#review1518 --- I like this change, makes sense with your explanation. What do you th

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-17 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/ --- (Updated 2011-08-17 15:18:59.396755) Review request for shindig. Changes -

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-16 Thread Dan Dumont
> On 2011-08-16 17:24:01, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 47 > > > > > > Why does the definition registerOn

Re: Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-16 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/#review1479 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Review Request: Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler

2011-08-16 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1525/ --- Review request for shindig. Summary --- If gadgets.util.registerOnLoadHandl