Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-02 Thread Ryan Baxter
> On 2011-11-02 00:28:45, Ryan Baxter wrote: > > One small nit, otherwise LGTM Committed revision 1196683. - Ryan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2648/#review3003

Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-02 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2648/#review3012 --- Ship it! LGTM! - Dan On 2011-11-01 18:12:28, Stanton Sievers wrote

Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-02 Thread Jesse Ciancetta
> On 2011-11-01 19:00:41, Jesse Ciancetta wrote: > > This looks good to me, however if we're going to go this route I wouldn't > > mind seeing the BlobCrypterSecurityTokenCodec changed to always expect to > > get the actual token key from ContainerConfig -- and then making the code > > that pa

Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-01 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2648/#review3003 --- Ship it! One small nit, otherwise LGTM http://svn.apache.org/repos/

Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-01 Thread Stanton Sievers
> On 2011-11-01 19:00:41, Jesse Ciancetta wrote: > > This looks good to me, however if we're going to go this route I wouldn't > > mind seeing the BlobCrypterSecurityTokenCodec changed to always expect to > > get the actual token key from ContainerConfig -- and then making the code > > that pa

Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-01 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2648/#review2993 --- Ship it! This looks good to me, however if we're going to go this rou

Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-01 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2648/ --- (Updated 2011-11-01 18:12:28.326279) Review request for shindig, Ryan Baxter and

Re: Review Request: Allow the blob crypter encryption key to be provided explicitly in the config

2011-11-01 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2648/ --- (Updated 2011-11-01 17:16:16.418233) Review request for shindig, Ryan Baxter and