Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
> On 2011-10-20 20:45:34, Jesse Ciancetta wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java, > > line 24 > > > > > > Unused import fixed > On 2011-10-20 20:45:34, Jesse C

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2724 --- Ship it! - Henry On 2011-10-20 18:54:27, Paul Lindner wrote: > > -

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Jesse Ciancetta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2722 --- Ship it! Found a few small items which I noted -- other than those LG

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2718 --- Ship it! LGTM - Ryan On 2011-10-20 18:54:27, Paul Lindner wrote: >

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Dan Dumont
> On 2011-10-20 18:09:06, Dan Dumont wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/RewritePath.java, > > line 58 > > > > > > StringBuilder? > > Paul Lindner wrote: > nah. Why not?

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/ --- (Updated 2011-10-20 18:54:27.879369) Review request for shindig. Summary -

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
> On 2011-10-20 18:09:06, Dan Dumont wrote: > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJslInfoVariableProcessor.java, > > line 89 > > > > > > Is there a performance implication here? I actual

Re: Review Request: Java hygiene for shindig

2011-10-20 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/#review2708 --- I've also been meaning to ask you about the whitespace nits. Is there

Review Request: Java hygiene for shindig

2011-10-20 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2475/ --- Review request for shindig. Summary --- Java hygiene for shindig * Fix jav