Re: Review Request: Locked domain cleanup and shared-domain-locking feature

> On 2011-10-03 19:04:01, Jesse Ciancetta wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java, > > line 315 > > > > > > You could co

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 19:58:37.102473) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 19:18:41.510554) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2269 --- Ship it! I found two small nits that you could take or leave which I

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 14:30:19.987345) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-10-03 14:26:22.765398) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

> On 2011-09-30 14:14:44, Jesse Ciancetta wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java, > > line 164 > > > > > > It looks lik

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-09-30 19:56:46.329747) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2219 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2216 --- Overall the patch looks pretty good to me -- it's nice to see the clea

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-09-29 17:03:35.492298) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-09-27 13:25:17.798472) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-09-26 13:11:12.939850) Review request for shindig, Paul Lindner, j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2048 --- LGTM - Ryan On 2011-09-22 21:35:24, Dan Dumont wrote: > >

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2038 --- Yes. - Dan On 2011-09-22 21:35:24, Dan Dumont wrote: > > -

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2031 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

domain cleanup and shared-domain-locking feature Dan, Could you create a JIRA issue for this? This will help us to chase down errors and patches history. - Henry On Thu, Sep 22, 2011 at 1:55 PM, Dan Dumont wrote: > > --- > T

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- (Updated 2011-09-22 21:35:24.891337) Review request for shindig, johnfargo, Ryan

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

Dan, Could you create a JIRA issue for this? This will help us to chase down errors and patches history. - Henry On Thu, Sep 22, 2011 at 1:55 PM, Dan Dumont wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/#review2028 --- The first pass of this looks ok. http://svn.apache.org/repos/asf/shi

Review Request: Locked domain cleanup and shared-domain-locking feature

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2025/ --- Review request for shindig, johnfargo, Ryan Baxter, and Stanton Sievers. Summary