Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2012-06-26 Thread ddumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/ --- (Updated June 26, 2012, 6:46 p.m.) Review request for shindig. Description ---

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-10-12 Thread Eric Woods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/#review2540 --- Ship it! Patch applied! - Eric On 2011-10-10 20:41:02, Eric Woods

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-10-10 Thread Eric Woods
> On 2011-09-29 17:51:35, Ryan Baxter wrote: > > This is my quick review. I am not expert on OAuth2 so this was purely from > > a code perspective. It would be great is people who already have oauth2 > > implementations could review this code. Most of my comments are below, but > > I have s

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-10-10 Thread Eric Woods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/ --- (Updated 2011-10-10 20:41:02.373211) Review request for shindig. Changes -

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-10-10 Thread Eric Woods
> On 2011-09-29 23:36:00, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/sampledata/canonicaldb.json, > > line 639 > > > > > > Tabs instead of spaces? Fixed. > On 2011-09-29 23:36:00, H

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/#review2165 --- So much code =) Just initial review. http://svn.apache.org/repos/asf

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-29 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/#review2157 --- This is my quick review. I am not expert on OAuth2 so this was purely

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-22 Thread Eric Woods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/ --- (Updated 2011-09-22 19:17:13.697848) Review request for shindig. Changes -

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-20 Thread Matt Marum
> On 2011-09-20 09:01:22, Paul Lindner wrote: > > wow, lots of code here. Only skimmed. In terms of style there's lots of > > tabs and trailing white space. > > > > For function please consider looking at what's coming in shiro 1.2: > > > > https://issues.apache.org/jira/browse/SHIRO-119 > >

Re: Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-20 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/#review1971 --- wow, lots of code here. Only skimmed. In terms of style there's lots

Review Request: OAuth 2.0 service provider implementation in Apache Shindig.

2011-09-16 Thread Eric Woods
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1940/ --- Review request for shindig. Summary --- OAuth 2.0 service provider implemen