Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-25 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/#review9443 --- Adam, could you please close this review and JIRA? - Dan Dumont On

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-24 Thread Ryan Baxter
> On July 24, 2012, 7:24 p.m., Matt Franklin wrote: > > Was this applied yet? > > Stanton Sievers wrote: > No, not yet. Consider this last call. If there are no other comments > I'll commit the patch in the next day. I committed this so we can get it in beta3 which I want to work on toni

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-24 Thread Stanton Sievers
> On July 24, 2012, 7:24 p.m., Matt Franklin wrote: > > Was this applied yet? No, not yet. Consider this last call. If there are no other comments I'll commit the patch in the next day. - Stanton --- This is an automatically generate

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-24 Thread Matt Franklin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/#review9405 --- Ship it! Was this applied yet? - Matt Franklin On July 18, 2012, 7

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-18 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/#review9266 --- Ship it! Looks good Adam thanks for doing this! I would give you a h

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-18 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/#review9262 --- Ship it! Small javadoc issue. Other than that, this looks good. ht

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-18 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/ --- (Updated July 18, 2012, 7:45 p.m.) Review request for shindig, Ryan Baxter and S

Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-18 Thread Adam Clarke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6035/ --- Review request for shindig, Ryan Baxter and Stanton Sievers. Description ---