Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5526 --- Ship it! Committed revision 1295877. - Stanton On 2012-02-29 21:30

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5475 --- If there are no other questions/issues I'll go ahead and commit this t

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

> On 2012-02-29 21:43:25, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java, > > line 563 > > > > > > Wouldnt we w

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5469 --- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/j

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/ --- (Updated 2012-02-29 21:30:23.106625) Review request for shindig, li xu and Adam

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5467 --- Ship it! +1 - Henry On 2012-02-21 21:40:31, Stanton Sievers wrote:

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5466 --- Ship it! OAuth 2.0 spec says response codes from the resource server

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

> On 2012-02-22 03:03:25, li xu wrote: > > LGTM. Thanks! Sorry,missed previous comments. Second thought after reading it and checking a few web links, I agree more thoughts on "403" will be needed. The reason about "403" may not be token related...it's common to return "403" with a reason lik

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5259 --- Ship it! LGTM. Thanks! - li On 2012-02-21 21:40:31, Stanton Siever

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

> On 2012-02-22 00:39:19, Ryan Baxter wrote: > > LGTM. This seems reasonable. I took a quick peak at the OAuth 2 spec and > > it didnt seem to go into any details on this. You might want to post > > something on the OAuth mailing list to see if anyone there has any thoughts. The only detail

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5255 --- Ship it! LGTM. This seems reasonable. I took a quick peak at the OA

Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/ --- Review request for shindig, li xu and Adam Clarke. Summary --- >From JIRA: