Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-23 Thread Ryan Baxter
> On 2011-08-22 22:09:28, johnfargo wrote: > > This solution looks pretty good to me. Removing from the map in the > > gadgetSite.close() sounds like a reasonable solution to me. Another is just > > to remove the sameDomain function map from rpc. > > > > The potential downside to the latter is

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-22 Thread johnfargo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1428/#review1592 --- Ship it! This solution looks pretty good to me. Removing from the map

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-22 Thread Ryan J Baxter
PM Subject:Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail Hey Ryan, I'm taking a look @ the review shortly. Re: using window.frames, the original reason was basically laziness. For parent-to-child communication, we cou

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-22 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1428/ --- (Updated 2011-08-22 12:57:34.689828) Review request for shindig, johnfargo and D

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-11 Thread Ryan J Baxter
:55 PM Subject:Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail Hey Ryan, I'm taking a look @ the review shortly. Re: using window.frames, the original reason was basically laziness. For parent-to-child communication, we cou

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-10 Thread Ryan J Baxter
/Westford/IBM@Lotus, dev@shindig.apache.org, Ryan Baxter Date: 08/10/2011 03:55 PM Subject:Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail Hey Ryan, I'm taking a look @ the review shortly. Re: using window.frames, the ori

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-10 Thread John Hjelmstad
"shindig" , "Ryan Baxter" < > rbaxte...@gmail.com> > Date: 08/09/2011 01:57 PM > Subject:Review Request: RPC calls coming from iFrames within the > same domain when using the same site id fail > -- > > >

Re: Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-09 Thread Ryan J Baxter
8-899-3041 developerWorks Profile From: "Ryan Baxter" To: johnfa...@gmail.com, Dan Dumont/Westford/IBM@Lotus, Cc: "shindig" , "Ryan Baxter" Date: 08/09/2011 01:57 PM Subject: Review Request: RPC calls coming from iFrames within the same doma

Review Request: RPC calls coming from iFrames within the same domain when using the same site id fail

2011-08-09 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1428/ --- Review request for shindig, johnfargo and Dan Dumont. Summary --- I think I