Re: Review Request: Remove Quirks Mode PHP Implementation

2011-08-26 Thread Paul Lindner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1655/#review1659 --- Ship it! lgtm - Paul On 2011-08-25 12:02:06, Bastian Hofmann

Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Bastian Hofmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1655/ --- Review request for shindig. Summary --- See

Re: Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1655/#review1640 --- /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php

Re: Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Bastian Hofmann
On 2011-08-25 14:21:43, Henry Saputra wrote: /trunk/php/src/gadgets/render/GadgetHtmlRenderer.php, line 44 https://reviews.apache.org/r/1655/diff/1/?file=35515#file35515line44 Is this to check if view name requested is quirks? No, in the PHP implementation so far you could add a

Re: Review Request: Remove Quirks Mode PHP Implementation

2011-08-25 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1655/#review1648 --- Ship it! +1 - Henry On 2011-08-25 12:02:06, Bastian Hofmann