Re: Review Request: Selection feature implementation does not match spec

2011-08-24 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1615/#review1618 --- Ship it! Committed revision 1161102. Please close the JIRA with this

Re: Review Request: Selection feature implementation does not match spec

2011-08-24 Thread Ryan Baxter
> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js, > > line 84 > > > > > > Shouldn't there be a test for remov

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Matthew Hatem
> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, > > line 96 > > > > > > How does this ever get called?

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Ryan Baxter
> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, > > line 96 > > > > > > How does this ever get called?

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Matthew Hatem
> On 2011-08-24 00:22:17, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, > > line 96 > > > > > > How does this ever get called?

Re: Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1615/#review1604 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Review Request: Selection feature implementation does not match spec

2011-08-23 Thread Matthew Hatem
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1615/ --- Review request for shindig and Ryan Baxter. Summary --- https://issues.apac