Re: Review Request: configurable to support different SHA algorithm

2013-06-20 Thread Ryan Baxter
> On May 22, 2013, 12:55 a.m., Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/crypto/BasicBlobCrypter.java, > > line 81 > > > > > > Small st

Re: Review Request: configurable to support different SHA algorithm

2013-06-05 Thread Zhi Hong Yang
> On May 22, 2013, 12:55 a.m., Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties, > > lines 228-229 > > > > > > It is not clear to me why these are lists. Th

Re: Review Request: configurable to support different SHA algorithm

2013-06-05 Thread Zhi Hong Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11299/ --- (Updated June 6, 2013, 2:41 a.m.) Review request for shindig, Ryan Baxter, Dan

Re: Review Request: configurable to support different SHA algorithm

2013-05-31 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11299/#review21281 --- Any JIRA opened for these proposed changes? - Henry Saputra On Ma

Re: Review Request: configurable to support different SHA algorithm

2013-05-31 Thread Ryan Baxter
> On May 22, 2013, 12:55 a.m., Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties, > > lines 228-229 > > > > > > It is not clear to me why these are lists. Th

Re: Review Request: configurable to support different SHA algorithm

2013-05-31 Thread Rich Thompson
> On May 22, 2013, 12:55 a.m., Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties, > > lines 228-229 > > > > > > It is not clear to me why these are lists. Th

Re: Review Request: configurable to support different SHA algorithm

2013-05-31 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11299/#review21271 --- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/

Re: Review Request: configurable to support different SHA algorithm

2013-05-31 Thread Dan Dumont
> On May 22, 2013, 12:55 a.m., Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties, > > lines 228-229 > > > > > > It is not clear to me why these are lists. Th

Re: Review Request: configurable to support different SHA algorithm

2013-05-29 Thread Zhi Hong Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11299/ --- (Updated May 29, 2013, 7:27 a.m.) Review request for shindig, Ryan Baxter, Dan

Re: Review Request: configurable to support different SHA algorithm

2013-05-21 Thread Ryan Baxter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11299/#review20879 --- Can you elaborate on how this effects OAuth? It looks like that it

Re: Review Request: configurable to support different SHA algorithm

2013-05-21 Thread Stanton Sievers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11299/#review20878 --- In general I'd like to see some tests using the other supported HMAC

Review Request: configurable to support different SHA algorithm

2013-05-21 Thread Zhi Hong Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11299/ --- Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich T