Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-13 Thread rbaxter85
Changed variable name http://codereview.appspot.com/6305079/

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-13 Thread rbaxter85
On 2012/06/12 13:34:52, rbaxter85 wrote: Changed variable name Committed http://codereview.appspot.com/6305079/

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-12 Thread TheMistyMay
http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java File java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java (right): http://codereview.appspot.com/6305079/diff/6001/java/socia

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread DouglasLDavies
http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java File java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java (right): http://codereview.appspot.com/6305079/diff/6001/java/socia

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread rbaxter85
Updated comments http://codereview.appspot.com/6305079/

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread rbaxter85
http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java File java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java (right): http://codereview.appspot.com/6305079/diff/6001/java/socia

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread sieverssj
LGTM. http://codereview.appspot.com/6305079/

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread TheMistyMay
Other than the null comment...LGTM Applied patch and ran tests, all successful. Ship it! http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java File java/social-api/src/main/java/org/apache/shindig/social/opensocial/s

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread daviesd
Not to get greedy about all the stuff I need for beta2, but... :) Ryan, is this going in before you do the beta2 rebuild? Thanks for all your help on getting these things resolved so quickly. I'm still testing this fix, but having maven repo issues this morning, and I was trying to apply the fix

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread rbaxter85
Updated based on Doug's suggestions. http://codereview.appspot.com/6305079/

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-11 Thread DouglasLDavies
http://codereview.appspot.com/6305079/diff/6001/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java File java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java (right): http://codereview.appspot.com/6305079/diff/6001/java/social-api/sr

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-10 Thread DouglasLDavies
http://codereview.appspot.com/6305079/diff/1002/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java File java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java (right): http://codereview.appspot.com/6305079/diff/1002/java/social-api/sr

Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-10 Thread rbaxter85
Reviewers: daviesd_oclc.org, themistymay_gmail.com, dev_shindig.apache.org, Description: If you try to create a GroupId with a non standard @ id an IllegalArgumentException will be thrown. This is because we default the type to ObjectId and @ is not a valid character in an ObjectId. Please revie

Re: Using custom @ ids GroupIds throws IllegalArgumentException (issue 6305079)

2012-06-10 Thread rbaxter85
Updated patch http://codereview.appspot.com/6305079/