trunk unstable...

2010-03-16 Thread Paul Lindner
Hi, I've been digging back into the source and found a few things of note: DefaultConcatUri causes many gadgets to fail because it has a hardcoded hostname of localhost:9003 I'll probably reuse the %host% idiom to get this to pass for the moment.. The end-to-end tests are ignoring their errors,

Re: trunk unstable...

2010-03-16 Thread John Hjelmstad
On Tue, Mar 16, 2010 at 12:43 PM, Paul Lindner wrote: > Hi, > > I've been digging back into the source and found a few things of note: > > DefaultConcatUri causes many gadgets to fail because it has a hardcoded > hostname of localhost:9003 I'll probably reuse the %host% idiom to get this > to pass

Re: trunk unstable...

2010-03-16 Thread Paul Lindner
actually it was samplecontainer that was broken. If you load any gadget with script tags you'll get failures (such as labpixies.. etal) On Tue, Mar 16, 2010 at 1:16 PM, John Hjelmstad wrote: > On Tue, Mar 16, 2010 at 12:43 PM, Paul Lindner >wrote: > > > Hi, > > > > I've been digging back into

Re: trunk unstable...

2010-03-16 Thread John Hjelmstad
Yeah... the additional parsing restrictions were a mistake. I've got one CL (which you reviewed) pulling back the host verification stuff, and Ziv is easing up the start/end beacon parsing thing as well. --John On Tue, Mar 16, 2010 at 1:29 PM, Paul Lindner wrote: > actually it was samplecontain

Re: trunk unstable...

2010-03-16 Thread John Hjelmstad
PS. It'd be nice to have some kind of automated sanity check for samplecontainer, if we indeed consider it a 1st class offering in Shindig. Sigh.. On Tue, Mar 16, 2010 at 2:01 PM, John Hjelmstad wrote: > Yeah... the additional parsing restrictions were a mistake. I've got one CL > (which you rev

Re: trunk unstable...

2010-03-16 Thread Paul Lindner
ah, nice. could you apply that then? I have enough changes coming down the pipe without me touching something that you're actively refactoring... On Tue, Mar 16, 2010 at 2:01 PM, John Hjelmstad wrote: > Yeah... the additional parsing restrictions were a mistake. I've got one CL > (which you r

Re: trunk unstable...

2010-03-16 Thread John Hjelmstad
Yes, both cls will be committed today. On Tuesday, March 16, 2010, Paul Lindner wrote: > ah, nice.  could you apply that then?  I have enough changes coming down the > pipe without me touching something that you're actively refactoring... > > > On Tue, Mar 16, 2010 at 2:01 PM, John Hjelmstad wro

Re: trunk unstable...

2010-03-16 Thread Paul Lindner
okay, looks like these changes don't overlap, so I'll go ahead with my commits. thanks! On Tue, Mar 16, 2010 at 2:22 PM, John Hjelmstad wrote: > Yes, both cls will be committed today. > > On Tuesday, March 16, 2010, Paul Lindner wrote: > > ah, nice. could you apply that then? I have enough

Re: trunk unstable...

2010-03-17 Thread Chirag Shah
It looks like most osapi methods aren't working for me on trunk. Is this true for anybody else? Here's the gadget i'm using: http://etherpad.com/ep/pad/export/osapi/latest?format=txt http://etherpad.com/osapi -Chirag On Tue, Mar 16, 2010 at 4:55 PM, Paul Lindner wrote: > okay, looks like these

Re: trunk unstable...

2010-03-17 Thread Paul Lindner
Right now I can't connect to etherpad.com.. Can you send the sample code? The gadgets in the endtoend test use osapi and they're working fine. On Wed, Mar 17, 2010 at 10:09 AM, Chirag Shah wrote: > It looks like most osapi methods aren't working for me on trunk. Is this > true for anybody else

Re: trunk unstable...

2010-03-17 Thread Chirag Shah
Ah sorry about that. Here's the gadget that's failing for me. It complains about getViewer being unknown. Does it work for you? Thanks, Chirag On Wed, Mar 17, 2010 at 1:46 PM, Paul Lindner wrote: > Right now I can't connect to etherpad.com.. Can you send the sample code? > > The

Re: trunk unstable...

2010-03-17 Thread Paul Lindner
Looks like osapi peoplehelpers are defined in a onload handler, your code runs before then. If you wrap it like this it should work: gadgets.util.registerOnLoadHandler(function() { ... }); On Wed, Mar 17, 2010 at 12:13 PM, Chirag Shah wrote: > Ah sorry about that. Here's the gadget that's f