[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517752959 @fpapon rebased, conflict resolved, built with "mvn clean install" with no errors, and branch force-pushed

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-08-02 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-517705111 @bdemers @fpapon Should I resolve the conflict and re-push? This is an

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-07-27 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-515669920 > Hi @steinarb , any update about the ICLA? Hi @fpapon I understood from the comment by @bdemers above that it was OK...? In my

[GitHub] [shiro] steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm

2019-05-30 Thread GitBox
steinarb commented on issue #138: Support base64 encoded salt in JdbcRealm URL: https://github.com/apache/shiro/pull/138#issuecomment-497344471 > @steinarb Looks good to me! can you sign an Apache CLA? https://www.apache.org/licenses/#contributor-license-agreements @bdemers I have