[Question] Shiro2CryptFormat for KDF support: Argon2, scrypt, bcrypt

2021-01-04 Thread Benjamin Marwell
Hi everyone! There’s a new draft PR [1] for SHIRO-290 [2] which enables argon2, scrypt (tbd), bcrypt. I need a design decision here before I can continue. I would like to introduce a Shiro2 CryptFormat which can hold parameters other than just the iteration count, and also the version. E.g. argon

Re: [Question] Shiro2CryptFormat for KDF support: Argon2, scrypt, bcrypt

2021-01-05 Thread Francois Papon
Hi Benjamin, I like the idea of a new Shiro2 CryptFormat with parameters. About the bcrypt or OpenBSD-Bcrypt-Base64, I think we can drop some old crypt format, so I'm agree to ditch them. regards, François fpa...@apache.org Le 04/01/2021 à 15:33, Benjamin Marwell a écrit : > Hi everyone! > > T

Re: [Question] Shiro2CryptFormat for KDF support: Argon2, scrypt, bcrypt

2021-01-07 Thread Benjamin Marwell
Hi everyone, argon2 and bcrypt are now implemented via the new default Shiro2 format. It is fully backwards compatible with the Shiro1 crypt format. Current PR: https://github.com/apache/shiro/pull/273 I would need a second look at the only failing test: DefaultPasswordService.testStringCompariso

Re: [Question] Shiro2CryptFormat for KDF support: Argon2, scrypt, bcrypt

2021-01-07 Thread Francois Papon
Hi Benjamin, I will take a look at your PR soon. regards, François fpa...@apache.org Le 07/01/2021 à 09:19, Benjamin Marwell a écrit : > Hi everyone, > > argon2 and bcrypt are now implemented via the new default Shiro2 format. > It is fully backwards compatible with the Shiro1 crypt format. > C