Re: Code Review

2015-06-17 Thread Thejas Nair
+1 having a code style is critical for open source projects with many contributors. Once a style is agreed upon, I think it should be added in http://singa.incubator.apache.org/develop/contribute-code.html . Committers reviewing the code should then check if it follows the style. If you can setup

[jira] [Created] (SINGA-18) update API for displaying performance metric

2015-06-17 Thread ZHAOJING (JIRA)
ZHAOJING created SINGA-18: - Summary: update API for displaying performance metric Key: SINGA-18 URL: https://issues.apache.org/jira/browse/SINGA-18 Project: Singa Issue Type: New Feature

[jira] [Resolved] (SINGA-7) Implement shared memory Hogwild algorithm

2015-06-17 Thread wangwei (JIRA)
[ https://issues.apache.org/jira/browse/SINGA-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangwei resolved SINGA-7. - Resolution: Fixed > Implement shared memory Hogwild algorithm > - > >

[jira] [Resolved] (SINGA-15) Fixg a bug from ConnectStub function which gets stuck for connecting layer_dealer_

2015-06-17 Thread wangwei (JIRA)
[ https://issues.apache.org/jira/browse/SINGA-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangwei resolved SINGA-15. -- Resolution: Fixed > Fixg a bug from ConnectStub function which gets stuck for connecting > layer_dealer_ > --

[jira] [Commented] (SINGA-17) Add root permission within thirdparty/install.

2015-06-17 Thread wangwei (JIRA)
[ https://issues.apache.org/jira/browse/SINGA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589709#comment-14589709 ] wangwei commented on SINGA-17: -- There is one problem for installing czmq ./install czmq /u

[jira] [Updated] (SINGA-17) Add root permission within thirdparty/install.

2015-06-17 Thread wangwei (JIRA)
[ https://issues.apache.org/jira/browse/SINGA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangwei updated SINGA-17: - Assignee: Xie Zhongle > Add root permission within thirdparty/install. > ---

[jira] [Updated] (SINGA-17) Add root permission within thirdparty/install.

2015-06-17 Thread Xie Zhongle (JIRA)
[ https://issues.apache.org/jira/browse/SINGA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xie Zhongle updated SINGA-17: - Summary: Add root permission within thirdparty/install. (was: Add root permission within thirdparty/install

[jira] [Created] (SINGA-17) Add root permission within thirdparty/install,

2015-06-17 Thread Xie Zhongle (JIRA)
Xie Zhongle created SINGA-17: Summary: Add root permission within thirdparty/install, Key: SINGA-17 URL: https://issues.apache.org/jira/browse/SINGA-17 Project: Singa Issue Type: Improvement

Code Review

2015-06-17 Thread Wang Wei
Hi guys, Please do a code review when you are getting familiar with the current code. It is important to make the code clean and easy to read for our first release. We tried to follow the Google's C++ code style initially. But didn't do it exactly. If no other suggestions for the coding style, pl

[jira] [Commented] (SINGA-16) Runtime Process id Management

2015-06-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SINGA-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589449#comment-14589449 ] ASF subversion and git services commented on SINGA-16: -- Commit 51a924da

[jira] [Commented] (SINGA-16) Runtime Process id Management

2015-06-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SINGA-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589448#comment-14589448 ] ASF subversion and git services commented on SINGA-16: -- Commit da6e4dce