Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-31 Thread Sheng Wu
I think the key is not how gracefully shutdown, it is when should shutdown, and how to trigger it. kezhenxu94@163 于2020年3月31日 周二下午10:18写道: > Jacoco agent writes the execution data to the files, if the targeted JVM > does not shut down gracefully, the file is corrupted and cannot be > analyzed,

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-31 Thread kezhenxu94@163
Jacoco agent writes the execution data to the files, if the targeted JVM does not shut down gracefully, the file is corrupted and cannot be analyzed, see https://github.com/jacoco/jacoco/issues/901#issuecomment-508442946 > On Mar 31, 2020, at 21:43, Sheng Wu wrote: > > Hi Zhenxu > > Could

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-31 Thread kezhenxu94@163
I did a quick POC locally, it turns out the solution is possible, the code lines executed in the E2E can be tracked and analyzed [0] (I run a simple/JDK E2E test, and the coverage increase ~3.42%), I’ve also tagged the coverage with “E2E” [1]. The next step would be chained them up in the

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-30 Thread Sheng Wu
kezhenxu94@163 于2020年3月30日周一 下午11:59写道: > > > > On Mar 30, 2020, at 21:58, Sheng Wu wrote: > > > > Sheng Wu 于2020年3月30日 周一下午9:55写道: > > > >> > >> > >> kezhenxu94@apache 于2020年3月30日 周一下午9:11写道: > >> > >>> In essence, code coverage is a measurement of the code lines that > **have > >>> been

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-30 Thread kezhenxu94@163
> On Mar 30, 2020, at 21:58, Sheng Wu wrote: > > Sheng Wu 于2020年3月30日 周一下午9:55写道: > >> >> >> kezhenxu94@apache 于2020年3月30日 周一下午9:11写道: >> >>> In essence, code coverage is a measurement of the code lines that **have >>> been executed** during the tests, and the code lines that are executed

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-30 Thread Sheng Wu
Sheng Wu 于2020年3月30日 周一下午9:55写道: > > > kezhenxu94@apache 于2020年3月30日 周一下午9:11写道: > >> In essence, code coverage is a measurement of the code lines that **have >> been executed** during the tests, and the code lines that are executed in >> the tests are **covered** actually, no matter whether they

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-30 Thread Sheng Wu
kezhenxu94@apache 于2020年3月30日 周一下午9:11写道: > In essence, code coverage is a measurement of the code lines that **have > been executed** during the tests, and the code lines that are executed in > the tests are **covered** actually, no matter whether they are counted in > the coverage rate (~26%),

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-30 Thread kezhenxu94@apache
In essence, code coverage is a measurement of the code lines that **have been executed** during the tests, and the code lines that are executed in the tests are **covered** actually, no matter whether they are counted in the coverage rate (~26%), my idea is to let the coverage tool (Cobertura

Re: [DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-30 Thread Sheng Wu
Juan Pan 于2020年3月30日 周一下午6:59写道: > Hi, > I understand your concern. From my experience as PPMC of Apache > ShardingSphere, both UT and e2e are necessary. > > > UT focuses on a specific module, i.e., the part of the whole project, > especially like SW core module, > which is the most important and

Re:[DISCUSSION] Meaning of test coverage, how/whether should we improve it?

2020-03-30 Thread Juan Pan
Hi, I understand your concern. From my experience as PPMC of Apache ShardingSphere, both UT and e2e are necessary. UT focuses on a specific module, i.e., the part of the whole project, especially like SW core module, which is the most important and less changed. Those UTs guarantee each