Re: Please vote for SLING-2853

2013-05-05 Thread Carsten Ziegeler
+1, this looks really good to me; One thing we imho should discuss is whether this should be using the api package, like o.a.s.api.resource.collection; We could leave it in the separate bundle as is right now, and once we consider it stable, move the package to the official API package. Carsten

[jira] [Commented] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649346#comment-13649346 ] Alexander Klimetschek commented on SLING-2853: -- Here's my review of the patch

[jira] [Comment Edited] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649346#comment-13649346 ] Alexander Klimetschek edited comment on SLING-2853 at 5/5/13 2:52 PM:

[jira] [Commented] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649352#comment-13649352 ] Carsten Ziegeler commented on SLING-2853: - I agree that allowing for custom node

[jira] [Commented] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649358#comment-13649358 ] Alexander Klimetschek commented on SLING-2853: -- As we want to allow

[jira] [Commented] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Amit Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649385#comment-13649385 ] Amit Gupta commented on SLING-2853: --- If you look at the code, it's actually simpler.

[jira] [Comment Edited] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Amit Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649385#comment-13649385 ] Amit Gupta edited comment on SLING-2853 at 5/5/13 6:10 PM: --- If

[jira] [Commented] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649389#comment-13649389 ] Alexander Klimetschek commented on SLING-2853: -- See in my review above,

[jira] [Updated] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Amit Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gupta updated SLING-2853: -- Attachment: collection_v2.zip New path addressing some of the implementation comments.

[jira] [Commented] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Amit Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649399#comment-13649399 ] Amit Gupta commented on SLING-2853: --- new patch (addressing following comments) 1. BTW,

[jira] [Updated] (SLING-2853) Add ResourceCollection to Sling

2013-05-05 Thread Amit Gupta (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gupta updated SLING-2853: -- Attachment: collection_v3.zip removed getEntries in preference of getProperties in ResourceCollection.