In general I'm fine with this, however as Justin noted adding final to
some of the classes might break clients of Sling.
Marking an interface as ConsumerType means also we shouldn't change it,
right? (i'm fine with that, just clarifying)
Carsten
2013/8/5 Felix Meschberger fmesc...@adobe.com
Carsten Ziegeler created SLING-2994:
---
Summary: Update to latest SCR plugin
Key: SLING-2994
URL: https://issues.apache.org/jira/browse/SLING-2994
Project: Sling
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SLING-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2994.
-
Resolution: Fixed
Updated to version 1.14.0 and annotations version 1.9.6 in rev 1510862
Carsten Ziegeler created SLING-2995:
---
Summary: Update Maven Plugins to latest version
Key: SLING-2995
URL: https://issues.apache.org/jira/browse/SLING-2995
Project: Sling
Issue Type:
+1 to Javadoc.
I am tempted to -1 final, but I never say -1.
Every framework that has final, and doesn't do quite what is required
is a complete nightmare to use. I remember Hibernate in the early days
when everything was final, and nothing worked properly. It was
impossible to fix except by
[
https://issues.apache.org/jira/browse/SLING-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2995.
-
Resolution: Fixed
Updated in rev 1510863
Update Maven Plugins to
On 6 August 2013 07:14, Ian Boston i...@tfd.co.uk wrote:
Finally, ;) , last time I read the java memory management docs and
hotspot description, IIRC, final can prevent hotspot optimising the
code, so some versions strip it or ignore it. I would have to find the
detail to be certain of that.
[
https://issues.apache.org/jira/browse/SLING-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730490#comment-13730490
]
Carsten Ziegeler commented on SLING-2944:
-
I'm wondering if we shouldn't remove
Hi Ian,
I did so. But then I am facing more dependencies to be resolved. In import
package I have only *. Which means all importing (will have to change that
also, but hard to figure out which can be removed.). I added hector
dependency and added Transitive =true. Doesn't this Transitive =true
On Tue, Aug 6, 2013 at 12:10 PM, Dishara Wijewardana
ddwijeward...@gmail.com wrote:
com.google.common.base -- Cannot be resolved
com.google.common.collect -- Cannot be resolved
These are coming from Guava and Guava is a proper OSGi bundle.
Robert
--
Sent from my (old) computer
Hi,
On 6 August 2013 10:24, Robert Munteanu rob...@lmn.ro wrote:
On Tue, Aug 6, 2013 at 12:10 PM, Dishara Wijewardana
ddwijeward...@gmail.com wrote:
com.google.common.base -- Cannot be resolved
com.google.common.collect -- Cannot be resolved
These are coming from Guava and Guava is a
See https://builds.apache.org/job/sling-trunk-1.7/163/changes
Changes:
[cziegeler] SLING-2995 : Update Maven Plugins to latest version
[cziegeler] SLING-2994 : Update to latest SCR pljugin
--
[...truncated 25588 lines...]
Aug 06, 2013 9:58:22 AM
See https://builds.apache.org/job/sling-trunk-1.6/1791/changes
Changes:
[cziegeler] SLING-2995 : Update Maven Plugins to latest version
[cziegeler] SLING-2994 : Update to latest SCR pljugin
--
[...truncated 23642 lines...]
Aug 6, 2013 10:19:42 AM
[
https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler closed SLING-2988.
---
Support primitive types for ValueMap.get()
--
[
https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2988.
-
Resolution: Won't Fix
Support primitive types for ValueMap.get()
[
https://issues.apache.org/jira/browse/SLING-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730645#comment-13730645
]
Carsten Ziegeler commented on SLING-2988:
-
We discussed this in SLING-2712,
Hi,
i've the need for a custom log append not logging into a file. This is
something our current logging bundles do not support. By looking around
using logback could be an answer and I also found [1] where moving to
logback has already been discussed.
So I'm wondering what/how to this. One
[
https://issues.apache.org/jira/browse/SLING-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-2996:
Attachment: SLING-2996.patch
use project.* properties instead of pom.* properties
Oliver Lietz created SLING-2996:
---
Summary: use project.* properties instead of pom.* properties
Key: SLING-2996
URL: https://issues.apache.org/jira/browse/SLING-2996
Project: Sling
Issue Type:
[
https://issues.apache.org/jira/browse/SLING-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-2996:
---
Assignee: Carsten Ziegeler
use project.* properties instead of pom.* properties
[
https://issues.apache.org/jira/browse/SLING-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2996.
-
Resolution: Fixed
Thanks for your patch, I've applied it
use project.*
See
https://builds.apache.org/job/sling-samples-1.6/org.apache.sling.samples$org.apache.sling.samples.simple-demo/426/changes
Changes:
[cziegeler] SLING-2996 : use project.* properties instead of pom.* properties
. Apply patch from Oliver Lietz
--
Aug
See https://builds.apache.org/job/sling-samples-1.6/426/changes
Changes:
[cziegeler] SLING-2996 : use project.* properties instead of pom.* properties
. Apply patch from Oliver Lietz
--
[...truncated 1177 lines...]
Downloaded:
See
https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.contrib-testing/1030/
See https://builds.apache.org/job/sling-contrib-1.6/1030/changes
Justin Edelson created SLING-2997:
-
Summary: ResourceAccessSecurityImpl uses @Override for interface
methods, but does not declare compiler version as Java 6
Key: SLING-2997
URL:
[
https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-2997:
-
Assignee: Justin Edelson
ResourceAccessSecurityImpl uses @Override for interface
[
https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-2997:
--
Fix Version/s: Resource Access Gate 1.0.0
ResourceAccessSecurityImpl uses @Override for
[
https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-2997.
---
Resolution: Fixed
fixed in 1510969 by setting sling.java.version to 6
Hi,
I'd like to use BindingsValuesProvider services in my health check
module, to provide bindings like jmx for scripted health checks,
which should be ignored for general Sling scripting (or not - some
providers might apply to both general scripting and health checks).
I'm thinking of adding an
I'm not sure if I understand this 100% - from a scripting pov, how could I
set the usage value, let's say in a JSP (or any other script)?
Carsten
2013/8/6 Bertrand Delacretaz bdelacre...@apache.org
Hi,
I'd like to use BindingsValuesProvider services in my health check
module, to provide
Oliver Lietz created SLING-2998:
---
Summary: SlingAuthenticator fails because of pathInfo being null
Key: SLING-2998
URL: https://issues.apache.org/jira/browse/SLING-2998
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730855#comment-13730855
]
Carsten Ziegeler commented on SLING-2997:
-
Do we really want to require java 6
[
https://issues.apache.org/jira/browse/SLING-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-2998:
Attachment: SLING-2998.patch
SlingAuthenticator fails because of pathInfo being null
Am Freitag, 2. August 2013 schrieb Oliver Lietz:
Am Freitag, 2. August 2013 schrieb Felix Meschberger:
Hi
hello all,
hello Felix,
I would assume the Sling Authentication Service has HTTP Basic
Authentication enabled with preemptive support. This means a 401 response
is never sent.
[
https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-2987:
---
Attachment: webconsole-is-back.jpg
The webconsole plugin works again at revision
[
https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730854#comment-13730854
]
Bertrand Delacretaz edited comment on SLING-2987 at 8/6/13 3:20 PM:
[
https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13725058#comment-13725058
]
Bertrand Delacretaz edited comment on SLING-2987 at 8/6/13 3:19 PM:
On Tue, Aug 6, 2013 at 5:13 PM, Carsten Ziegeler cziege...@apache.org wrote:
I'm not sure if I understand this 100% - from a scripting pov, how could I
set the usage value, let's say in a JSP (or any other script)?
You set the usage property when you create a BindingsValuesProvider,
so for my
See https://builds.apache.org/job/sling-trunk-1.6/1792/changes
Changes:
[cziegeler] SLING-2996 : use project.* properties instead of pom.* properties
. Apply patch from Oliver Lietz
--
[...truncated 26767 lines...]
Aug 6, 2013 3:34:22 PM
I guess this only works as you have a special script engine for health
check, right?
What if people want to use the same functionality if they write lets say
workflow scripts or wcm scripts etc?
As long as there is no way to make use of this in every script engine, I
don't see the point of adding
On Tue, Aug 6, 2013 at 5:39 PM, Carsten Ziegeler cziege...@apache.org wrote:
I guess this only works as you have a special script engine for health
check, right?
Not really a special script engine, but I'm using the
ScriptEngineManager directly instead of going through SlingScript.
See code at
I think if we would be in the jsp world, you would do a taglib for this -
of course taglibs are not usable within other scripting languages - so
depending on your script language you would have to come up with the
equivalent.
Taglibs in JSP allow exactly what you want - the BVP is more a way to
[
https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730881#comment-13730881
]
Justin Edelson commented on SLING-2997:
---
I personally like having the @Override
And forgot to mention :) I think your current approach is fine, as these
objects are special objects for health checks, you have special execution
code and can handle it there.
Carsten
2013/8/6 Carsten Ziegeler cziege...@apache.org
I think if we would be in the jsp world, you would do a
[
https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730884#comment-13730884
]
Carsten Ziegeler commented on SLING-2997:
-
So could we simply set source fixed to
See https://builds.apache.org/job/sling-trunk-1.7/164/changes
Changes:
[cziegeler] SLING-2996 : use project.* properties instead of pom.* properties
. Apply patch from Oliver Lietz
--
[...truncated 23503 lines...]
Aug 06, 2013 4:19:35 PM
All,
My JIRA user 'klcodanr' does not seem to have sufficient permissions to
manage versions in JIRA, can I be granted sufficient permissions?
Thanks,
Dan
Hi Bertrand,
FWIW, I was thinking about something very similar (although I was thinking
of calling it 'scope', not 'usage'), but never got around to implementing
it.
+1 for me.
Justin
On Tue, Aug 6, 2013 at 10:58 AM, Bertrand Delacretaz bdelacre...@apache.org
wrote:
Hi,
I'd like to use
[
https://issues.apache.org/jira/browse/SLING-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730956#comment-13730956
]
Justin Edelson commented on SLING-2997:
---
I think so, but right now the parent pom
Ok, just to make it clear, as long as there is no support in all script
engines, I'm -1
Carsten
2013/8/6 Justin Edelson jus...@justinedelson.com
Hi Bertrand,
FWIW, I was thinking about something very similar (although I was thinking
of calling it 'scope', not 'usage'), but never got around
Hi Dan
I made you an administrator of the Sling project. Should work now, I hope.
Regards
Felix
Am 06.08.2013 um 18:33 schrieb Daniel Klco:
All,
My JIRA user 'klcodanr' does not seem to have sufficient permissions to
manage versions in JIRA, can I be granted sufficient permissions?
See https://builds.apache.org/job/sling-trunk-1.6/1793/changes
Changes:
[justin] SLING-2997 - setting sling.java.version to 6 for resource access gate
due to use of @Override
--
[...truncated 23649 lines...]
Aug 6, 2013 6:09:21 PM
Hi Carsten,
I can't speak for exactly what Bertrand is thinking, but when I was
thinking about it, the scope/usage was an orthogonal concern to which
engine is selected.
Whereas today you do:
ScriptEngineManager.getEngineByExtension(ecma)
You could do
See https://builds.apache.org/job/sling-trunk-1.7/165/changes
Changes:
[justin] SLING-2997 - setting sling.java.version to 6 for resource access gate
due to use of @Override
--
[...truncated 26672 lines...]
Aug 06, 2013 6:53:06 PM
Sorry to resurrect such an old thread, but I started this conversation 3
months ago and we aren't close to releasing Sling 7.
IMO the build server flakiness contributes to this uncertainty, but so
do a few or our tests, being unstable as well.
What I'd like to propose now is to make a very
I'm not totally against this, but just adhoc adding this property without a
complete concept seems wrong to me. Defining the technical selection
process (e.g. as you describe it) is one part, but the other equally
important part, how to select from a script dev point of view. How can I
write a JSP
I definitely agree that we should try to get Sling 6 out asap - and I think
we're pretty close to that. Apart maybe from a release of one or two
additional bundles, we need to release the discovery stuff (I plan to do
this end of this week/early next week) and the new admin login stuff Felix
is
58 matches
Mail list logo
