Re: [VOTE] Release Apache Sling JCR Resource 2.3.4

2014-03-17 Thread Carsten Ziegeler
Ping 2014-03-14 8:01 GMT-07:00 Carsten Ziegeler : > Anyone else? > > > 2014-03-11 19:34 GMT+01:00 Oliver Lietz : > > On Tuesday 11 March 2014 09:32:26 Carsten Ziegeler wrote: >> > Hi, >> > >> > this vote is about the release of >> > >> > Apache Sling JCR Resource 2.3.4 >> > which contains an imp

[jira] [Commented] (SLING-3457) Change ResourceUtil.isNonExistingResource(null) to return true instead of NPE.

2014-03-17 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937622#comment-13937622 ] Carsten Ziegeler commented on SLING-3457: - I'm not sure if we should do this. If t

RE: [RT] Make ResourceAccessSecurity always restrict access if installed and no ResourceAccessGate present

2014-03-17 Thread Marius Petria
> > Furthermore the implementation of the ResourceAccessSecurity for the > > provider context does not behave like the one for the application > > context: If we for example check the read access for a resource the > > implementation calls all ResourceAccessGates till a gate is found > > which gran

Re: [VOTE] Release Apache Sling JCR Resource 2.3.4

2014-03-17 Thread Justin Edelson
+1 On Tue, Mar 11, 2014 at 4:32 AM, Carsten Ziegeler wrote: > Hi, > > this vote is about the release of > > Apache Sling JCR Resource 2.3.4 > which contains an important bug fix: > https://issues.apache.org/jira/browse/SLING-3445 > > Staging repository: > https://repository.apache.org/content/rep

Re: [RT] Support for deep reads from a value map

2014-03-17 Thread Justin Edelson
OK. Thanks for explaining. Just wanted to make sure I wasn't missing something. Justin On Sun, Mar 16, 2014 at 5:46 AM, Carsten Ziegeler wrote: > Hi Justin > > it's right we can get the same result without adding this method, however > with adding this method we really make clear that there is a

[jira] [Commented] (SLING-3447) Add more Source and CI links to sidebar

2014-03-17 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937746#comment-13937746 ] Bertrand Delacretaz commented on SLING-3447: Note that you can also submit pat

[jira] [Commented] (SLING-3435) ResourceAccessSecurity does not secure access for update operations

2014-03-17 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937749#comment-13937749 ] Marius Petria commented on SLING-3435: -- Hi Mike, I tried to run the tests but they d

Re: [VOTE] Release Apache Sling Models Implementation 1.0.2

2014-03-17 Thread Bertrand Delacretaz
On Sat, Mar 15, 2014 at 3:57 PM, Justin Edelson wrote: > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1035/... +1 for the release, checked signatures, build, svn tag match on the following archive: MD5 org.apache.sling.models.impl-1.0.2-source-relea

SlingRepository Integration Tests fails on new system

2014-03-17 Thread Pontus Amberg
The SlingRepository Integration Tests (in /bundles/jcr/it-jackrabbit-ok/) fails on a new system. I'm not sure but I think the reason might be that JackrabbitRepositoryIT & OakRepositoryIT contains the line mavenBundle("org.apache.sling", "org.apache.sling.jcr.base", "2.2.1-SNAPSHOT"), and the cur

Re: [RT] Make ResourceAccessSecurity always restrict access if installed and no ResourceAccessGate present

2014-03-17 Thread Carsten Ziegeler
Yes, I think my first answer was wrong (Note to myself, don't answer mails after long distance travels...) and you're right. The difference between provider and application type is exactly that. If there is no provider RAS and the provider does not declare to require one, the resource is visible. S

[VOTE RESULT] Release Apache Sling JCR Resource 2.3.4

2014-03-17 Thread Carsten Ziegeler
The vote passes with three binding +1 votes from Justin Edelson, Felix Meschberger, and Carsten Ziegeler and one non binding +1 vote from Oliver Lietz Carsten -- Carsten Ziegeler cziege...@apache.org

[jira] [Closed] (SLING-3445) Removing multi value property fails

2014-03-17 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3445. --- > Removing multi value property fails > --- > > K

Re: [VOTE] Release Apache Sling Models Implementation 1.0.2

2014-03-17 Thread Carsten Ziegeler
+1 2014-03-17 6:48 GMT-07:00 Bertrand Delacretaz : > On Sat, Mar 15, 2014 at 3:57 PM, Justin Edelson > wrote: > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-1035/. > .. > > +1 for the release, checked signatures, build, svn tag match on the > f

Re: SlingRepository Integration Tests fails on new system

2014-03-17 Thread Bertrand Delacretaz
Hi, On Mon, Mar 17, 2014 at 3:22 PM, Pontus Amberg wrote: > ...I think the reason might be that JackrabbitRepositoryIT & > OakRepositoryIT contains the line > > mavenBundle("org.apache.sling", "org.apache.sling.jcr.base", > "2.2.1-SNAPSHOT"),... Thanks for reporting this, should be fixed by http

Re: SlingRepository Integration Tests fails on new system

2014-03-17 Thread Pontus Amberg
That seems to have solved to problem in the SlingRepository Integration Tests but there seems to be a similar problem in Scripting Core implementation (/bundles/scripting/core/) where BindingValuesProvidersByContextIT contains the line mavenBundle("org.apache.sling", "org.apache.sling.scripting.ap

[jira] [Resolved] (SLING-3352) Expose OSGI configuration via HTTP

2014-03-17 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili resolved SLING-3352. Resolution: Fixed Assignee: Tommaso Teofili (was: Carsten Ziegeler) I've applied Mar

RE: [RT] Make ResourceAccessSecurity always restrict access if installed and no ResourceAccessGate present

2014-03-17 Thread Mike Müller
> the current implementation does actually this (if I read the code > correctly) :) Yes you're right, the implementation for this case is correct. Sorry for the confusion... > If useRAS is set, but no Gate available, the resource is not returned. At > least > ProviderHandler#getReadableResource

Re: SlingRepository Integration Tests fails on new system

2014-03-17 Thread Bertrand Delacretaz
Hi, On Mon, Mar 17, 2014 at 3:56 PM, Pontus Amberg wrote: > ...there seems to > be a similar problem in Scripting Core implementation... That one should be fixed by revision 1578442 -Bertrand

RE: [RT] Make ResourceAccessSecurity always restrict access if installed and no ResourceAccessGate present

2014-03-17 Thread Mike Müller
Hi I think this is insecure by design and not correct: The problem is not, that we do grant access if no ResourceAccessGate is registered for application context. The problem is, that we grant access also if there is a ResourceAccessGate registered for application level but does return GateResult.

[jira] [Commented] (SLING-3435) ResourceAccessSecurity does not secure access for update operations

2014-03-17 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937936#comment-13937936 ] Mike Müller commented on SLING-3435: Hi Marius I just checked the code out again (fre

[jira] [Comment Edited] (SLING-3435) ResourceAccessSecurity does not secure access for update operations

2014-03-17 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937936#comment-13937936 ] Mike Müller edited comment on SLING-3435 at 3/17/14 4:03 PM: -

[jira] [Commented] (SLING-3435) ResourceAccessSecurity does not secure access for update operations

2014-03-17 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937959#comment-13937959 ] Marius Petria commented on SLING-3435: -- Hi, It must have been something wrong in my

RE: [RT] Make ResourceAccessSecurity always restrict access if installed and no ResourceAccessGate present

2014-03-17 Thread Marius Petria
I think the actual problem might be in the implementation of ProviderHandler. getReadableResource. The applicationsecurityservice should apply its restrictions to the already secured resource (returnValue) rather than on the initial resource. That way any constraint imposed by the providersecur

Performance and stability of Sling Models

2014-03-17 Thread Konrad Windszus
Hi, I am a little bit worried that model classes which leverage the Sling Models annotations might be slow and break fast. If you use the annotation @Inject without @Source all injectors are asked until one returns a value. Since almost all injectors depend on the fieldname and cover the same

Re: Performance and stability of Sling Models

2014-03-17 Thread Justin Edelson
Hi Konrad, (a) is correct and is intentional. Is there an actual situation where this would happen accidentially? In my experience, a new BVP is not added every day and has a broad impact. If you add a BVP without regressing your application, that's a problem into itself. (b) and (c) would only be

Re: SlingRepository Integration Tests fails on new system

2014-03-17 Thread Pontus Amberg
The build works fine now. Thanks for the quick fixes! /Pontus On 17 March 2014 16:36, Bertrand Delacretaz wrote: > Hi, > > On Mon, Mar 17, 2014 at 3:56 PM, Pontus Amberg > wrote: > > ...there seems to > > be a similar problem in Scripting Core implementation... > > That one should be fixed by

Resource rendered by .esp script is only rendered on first request

2014-03-17 Thread Pontus Amberg
I'm not sure but I think I might have encountered a problem in the current trunk with resources rendered by .esp scripts. Steps to reproduce: 1. Create a new file called test.esp with this content: <%="Current node path: "+currentNode.path%> 2. Copy the file to your repos

Re: [RT] Make ResourceAccessSecurity always restrict access if installed and no ResourceAccessGate present

2014-03-17 Thread Carsten Ziegeler
Hi 2014-03-17 8:38 GMT-07:00 Mike Müller : > Hi > > I think this is insecure by design and not correct: > The problem is not, that we do grant access if no ResourceAccessGate is > registered for application context. The problem is, that we grant access > also if there is a ResourceAccessGate reg