Re: [Sightly] API vs. Implementation

Hi Felix, The API reorganisation looks good to me. On Wed, Nov 19, 2014 at 10:49 PM, Felix Meschberger wrote: > Apart from splitting the base .api package, this are further discussions: > > * Exceptions are forming a hierarchy with SightlyEngineException being the > root and itself extending fr

[jira] [Created] (SLING-4189) Add basic code completion for Sightly

Robert Munteanu created SLING-4189: -- Summary: Add basic code completion for Sightly Key: SLING-4189 URL: https://issues.apache.org/jira/browse/SLING-4189 Project: Sling Issue Type: New Feat

[Sightly] API vs. Implementation

Hi TL;DR We have to cleanup APIs and exports from Sightly Engine and JS UseProvider bundles. I have been going through the Sightly Engine and JS UseProvider bundles. The JS UseProvider bundle currently exports everything at the bundle version. I would think this bundle should not be exporting

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2795

See

Jenkins build is unstable: sling-trunk-1.6 #2795

See

Jenkins build is still unstable: sling-trunk-1.7 #1177

See

Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1177

See

[jira] [Commented] (SLING-4138) Allow validator to support arbitrary types

[ https://issues.apache.org/jira/browse/SLING-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218173#comment-14218173 ] ASF GitHub Bot commented on SLING-4138: --- Github user kwin closed the pull request at

[GitHub] sling pull request: SLING-4138, refactor Validator interface

Github user kwin closed the pull request at: https://github.com/apache/sling/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[jira] [Commented] (SLING-4182) Cleanup Sightly Engine dependencies

[ https://issues.apache.org/jira/browse/SLING-4182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218153#comment-14218153 ] ASF GitHub Bot commented on SLING-4182: --- Github user asfgit closed the pull request

[jira] [Commented] (SLING-4176) Sightly: StyleToken context is doing nothing

[ https://issues.apache.org/jira/browse/SLING-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218152#comment-14218152 ] ASF GitHub Bot commented on SLING-4176: --- Github user asfgit closed the pull request

[jira] [Commented] (SLING-4167) The Sightly implementation should provide support for escaped expressions

[ https://issues.apache.org/jira/browse/SLING-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218151#comment-14218151 ] ASF GitHub Bot commented on SLING-4167: --- Github user asfgit closed the pull request

[jira] [Commented] (SLING-4180) Sightly Engine should properly reimport its own API export

[ https://issues.apache.org/jira/browse/SLING-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218150#comment-14218150 ] ASF GitHub Bot commented on SLING-4180: --- Github user asfgit closed the pull request

[GitHub] sling pull request: SLING-4167 - The Sightly implementation should...

Github user asfgit closed the pull request at: https://github.com/apache/sling/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] sling pull request: SLING-4176 - Added validation/filtering for St...

Github user asfgit closed the pull request at: https://github.com/apache/sling/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] sling pull request: SLING-4182 - Cleanup Sightly Engine dependenci...

Github user asfgit closed the pull request at: https://github.com/apache/sling/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] sling pull request: SLING-4180 - Sightly Engine should properly re...

Github user asfgit closed the pull request at: https://github.com/apache/sling/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1176

See

Jenkins build is still unstable: sling-trunk-1.7 #1176

See

Build failed in Jenkins: sling-contrib-1.6 #1365

See Changes: [kwin] SLILNG-4027 removal of ValidatorLookupService [fmeschbe] SLING-4185 The org.apache.sling.xss bundle should properly export its API Applying slightly modified patch by Radu Cotescu (Thanks alot). ---

[jira] [Assigned] (SLING-4027) Improvement of the validation API

[ https://issues.apache.org/jira/browse/SLING-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-4027: -- Assignee: Konrad Windszus > Improvement of the validation API > ---

[jira] [Commented] (SLING-4027) Improvement of the validation API

[ https://issues.apache.org/jira/browse/SLING-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218088#comment-14218088 ] Konrad Windszus commented on SLING-4027: I removed the {{ValidatorLookupService}}

[jira] [Resolved] (SLING-4185) The org.apache.sling.xss bundle should properly export its API

[ https://issues.apache.org/jira/browse/SLING-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-4185. -- Resolution: Fixed Thanks for providing the patch. I have applied it slightly modified in

Build failed in Jenkins: sling-contrib-1.6 #1364

See Changes: [kwin] SLING-4138, refactored Validator interface to support arbitrary types, arrays and cross-field validation -- Started by an SCM change Building remotely on ubuntu-1 (docker U

[jira] [Assigned] (SLING-4185) The org.apache.sling.xss bundle should properly export its API

[ https://issues.apache.org/jira/browse/SLING-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reassigned SLING-4185: Assignee: Felix Meschberger > The org.apache.sling.xss bundle should properly expor

[jira] [Commented] (SLING-4154) Discuss distribution components creation and configuration

[ https://issues.apache.org/jira/browse/SLING-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218039#comment-14218039 ] Felix Meschberger commented on SLING-4154: -- [~mpetria] Re "internal API": this is

[jira] [Commented] (SLING-4027) Improvement of the validation API

[ https://issues.apache.org/jira/browse/SLING-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218026#comment-14218026 ] Konrad Windszus commented on SLING-4027: b) and d) is solved with SLING-4138. With

[jira] [Commented] (SLING-4138) Allow validator to support arbitrary types

[ https://issues.apache.org/jira/browse/SLING-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218011#comment-14218011 ] Konrad Windszus commented on SLING-4138: I committed the changes from the Pull req

[jira] [Resolved] (SLING-4138) Allow validator to support arbitrary types

[ https://issues.apache.org/jira/browse/SLING-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-4138. Resolution: Fixed > Allow validator to support arbitrary types > ---

[jira] [Comment Edited] (SLING-4185) The org.apache.sling.xss bundle should properly export its API

[ https://issues.apache.org/jira/browse/SLING-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217944#comment-14217944 ] Radu Cotescu edited comment on SLING-4185 at 11/19/14 2:19 PM: -

[jira] [Updated] (SLING-4185) The org.apache.sling.xss bundle should properly export its API

[ https://issues.apache.org/jira/browse/SLING-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-4185: Attachment: SLING-4185.diff I attached a patch for this issue - see [^SLING-4185.diff]. Applying it

[jira] [Commented] (SLING-3959) Donation of the Sightly and XSS modules

[ https://issues.apache.org/jira/browse/SLING-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217920#comment-14217920 ] Bertrand Delacretaz commented on SLING-3959: Note that as part of SLING-4187 t

[jira] [Commented] (SLING-4188) EventHandlers registered for TOPIC_RESOURCE_REMOVED should get property values of deleted resource in handleEvent method.

[ https://issues.apache.org/jira/browse/SLING-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217911#comment-14217911 ] Carsten Ziegeler commented on SLING-4188: - I'm not against supporting this, howeve

[jira] [Updated] (SLING-4188) EventHandlers registered for TOPIC_RESOURCE_REMOVED should get property values of deleted resource in handleEvent method.

[ https://issues.apache.org/jira/browse/SLING-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated SLING-4188: - Component/s: JCR > EventHandlers registered for TOPIC_RESOURCE_REMOVED should get property

[jira] [Updated] (SLING-4188) EventHandlers registered for TOPIC_RESOURCE_REMOVED should get property values of deleted resource in handleEvent method.

[ https://issues.apache.org/jira/browse/SLING-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated SLING-4188: - Affects Version/s: JCR Resource 2.3.12 > EventHandlers registered for TOPIC_RESOURCE_REMOV

[jira] [Updated] (SLING-4188) EventHandlers registered for TOPIC_RESOURCE_REMOVED should get property values of deleted resource in handleEvent method.

[ https://issues.apache.org/jira/browse/SLING-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Himanshu Sawhney updated SLING-4188: Summary: EventHandlers registered for TOPIC_RESOURCE_REMOVED should get property values of d

Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Resource-Based Discovery Service #464

See

[jira] [Commented] (SLING-4188) EventHandlers registered for TOPIC_RESOURCE_REMOVED should get proverty values of deleted resource in handleEvent method

[ https://issues.apache.org/jira/browse/SLING-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217854#comment-14217854 ] Himanshu Sawhney commented on SLING-4188: - As per offline discussion with [~fmesch

[jira] [Comment Edited] (SLING-4188) EventHandlers registered for TOPIC_RESOURCE_REMOVED should get proverty values of deleted resource in handleEvent method

[ https://issues.apache.org/jira/browse/SLING-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217854#comment-14217854 ] Himanshu Sawhney edited comment on SLING-4188 at 11/19/14 12:59 PM:

Jenkins build is still unstable: sling-trunk-1.7 #1175

See

Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1175

See

Jenkins build is unstable: sling-trunk-1.6 #2793

See

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2793

See

[jira] [Created] (SLING-4188) EventHandlers registered for TOPIC_RESOURCE_REMOVED should get proverty values of deleted resource in handleEvent method

Himanshu Sawhney created SLING-4188: --- Summary: EventHandlers registered for TOPIC_RESOURCE_REMOVED should get proverty values of deleted resource in handleEvent method Key: SLING-4188 URL: https://issues.apache.

Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Resource-Based Discovery Service #463

See

Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1174

See

Jenkins build is unstable: sling-trunk-1.7 #1174

See

Build failed in Jenkins: sling-contrib-1.6 #1363

See Changes: [mpetria] SLING-4153: Making DistributionComponentFactory delegate creation of subcomponents [fmeschbe] SLING-4187 Move XSS and Validation to Extensions -- Started by an SCM chan

[jira] [Commented] (SLING-4154) Discuss distribution components creation and configuration

[ https://issues.apache.org/jira/browse/SLING-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217764#comment-14217764 ] Marius Petria commented on SLING-4154: -- [~cziegeler], [~fmeschbe], thanks for the (of

Re: XSS bundle location

Ok, moved both in Rev. 1640525 (SLING-4187) Regards Felix > Am 19.11.2014 um 12:15 schrieb Felix Meschberger : > > Hi > >> Am 19.11.2014 um 11:44 schrieb Oliver Lietz : >> >> On Wednesday 19 November 2014 09:54:05 Felix Meschberger wrote: >>> Hi all >>> >>> The XSS bundle is currently in the

[jira] [Resolved] (SLING-4187) Move validation and xss projects into contrib/extensions

[ https://issues.apache.org/jira/browse/SLING-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-4187. -- Resolution: Fixed Done in Rev. 1640525 > Move validation and xss projects into contrib/

[jira] [Created] (SLING-4187) Move validation and xss projects into contrib/extensions

Felix Meschberger created SLING-4187: Summary: Move validation and xss projects into contrib/extensions Key: SLING-4187 URL: https://issues.apache.org/jira/browse/SLING-4187 Project: Sling

Re: XSS bundle location

Hi > Am 19.11.2014 um 11:44 schrieb Oliver Lietz : > > On Wednesday 19 November 2014 09:54:05 Felix Meschberger wrote: >> Hi all >> >> The XSS bundle is currently in the contrib folder. IMHO it should be in >> contrib/extensions. >> >> Any opposition in me moving this bundle ? > > Same for val

Re: XSS bundle location

On Wed, Nov 19, 2014 at 9:54 AM, Felix Meschberger wrote: > The XSS bundle is currently in the contrib folder. IMHO it should be in > contrib/extensions. > Any opposition in me moving this bundle ?... Go ahead makes sense! -Bertrand

Re: XSS bundle location

On Wednesday 19 November 2014 09:54:05 Felix Meschberger wrote: > Hi all > > The XSS bundle is currently in the contrib folder. IMHO it should be in > contrib/extensions. > > Any opposition in me moving this bundle ? Same for validation, no? O. > Regards > Felix

[jira] [Commented] (SLING-4175) Sightly: Do not catch exceptions in ResourceRuntimeExtension and IncludeRuntimeExtension

[ https://issues.apache.org/jira/browse/SLING-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217675#comment-14217675 ] santiago garcía pimentel commented on SLING-4175: - Hello [~kwin] would the

[jira] [Commented] (SLING-4175) Sightly: Do not catch exceptions in ResourceRuntimeExtension and IncludeRuntimeExtension

[ https://issues.apache.org/jira/browse/SLING-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217674#comment-14217674 ] ASF GitHub Bot commented on SLING-4175: --- GitHub user santiagozky opened a pull reque

[GitHub] sling pull request: SLING-4175

GitHub user santiagozky opened a pull request: https://github.com/apache/sling/pull/45 SLING-4175 Would this patch be acceptable to fix https://issues.apache.org/jira/browse/SLING-4175 ? You can merge this pull request into a Git repository by running: $ git pull https://githu

[jira] [Created] (SLING-4186) Make org.apache.sling.i18n independent from JCR APIs

Timothee Maret created SLING-4186: - Summary: Make org.apache.sling.i18n independent from JCR APIs Key: SLING-4186 URL: https://issues.apache.org/jira/browse/SLING-4186 Project: Sling Issue Ty

[jira] [Comment Edited] (SLING-4154) Discuss distribution components creation and configuration

[ https://issues.apache.org/jira/browse/SLING-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217661#comment-14217661 ] Marius Petria edited comment on SLING-4154 at 11/19/14 9:47 AM:

[jira] [Commented] (SLING-4154) Discuss distribution components creation and configuration

[ https://issues.apache.org/jira/browse/SLING-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217661#comment-14217661 ] Marius Petria commented on SLING-4154: -- [~cziegeler] that is indeed a different optio

[jira] [Resolved] (SLING-4180) Sightly Engine should properly reimport its own API export

[ https://issues.apache.org/jira/browse/SLING-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-4180. -- Resolution: Fixed Thanks for providing the patch. I have applied it in Rev. 1640508. (I

[jira] [Assigned] (SLING-4180) Sightly Engine should properly reimport its own API export

[ https://issues.apache.org/jira/browse/SLING-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reassigned SLING-4180: Assignee: Felix Meschberger > Sightly Engine should properly reimport its own API e

Jenkins build is back to stable : sling-trunk-1.8 #462

See

Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #462

See

[jira] [Created] (SLING-4185) The org.apache.sling.xss bundle should properly export its API

Radu Cotescu created SLING-4185: --- Summary: The org.apache.sling.xss bundle should properly export its API Key: SLING-4185 URL: https://issues.apache.org/jira/browse/SLING-4185 Project: Sling I

[jira] [Resolved] (SLING-4167) The Sightly implementation should provide support for escaped expressions

[ https://issues.apache.org/jira/browse/SLING-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-4167. -- Resolution: Fixed Fix Version/s: Scripting Sightly Engine 1.0.0 Thanks for provid

[jira] [Commented] (SLING-4154) Discuss distribution components creation and configuration

[ https://issues.apache.org/jira/browse/SLING-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217632#comment-14217632 ] Carsten Ziegeler commented on SLING-4154: - If none is perfect, we have to find the

Build failed in Jenkins: sling-trunk-1.6 #2791

See -- [...truncated 2647 lines...] AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/builder/ContentBuilderTest.java A testing/mocks/sling-mock/src/test/java/

[jira] [Assigned] (SLING-4167) The Sightly implementation should provide support for escaped expressions

[ https://issues.apache.org/jira/browse/SLING-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reassigned SLING-4167: Assignee: Felix Meschberger > The Sightly implementation should provide support for

[jira] [Updated] (SLING-4176) Sightly: StyleToken context is doing nothing

[ https://issues.apache.org/jira/browse/SLING-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated SLING-4176: - Component/s: Extensions Fix Version/s: XSS Protection API 1.0.0 > Sightly: StyleToke

[jira] [Resolved] (SLING-4176) Sightly: StyleToken context is doing nothing

[ https://issues.apache.org/jira/browse/SLING-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-4176. -- Resolution: Fixed Thanks for providing the patch. I have applied it in Rev. 1640505 >

XSS bundle location

Hi all The XSS bundle is currently in the contrib folder. IMHO it should be in contrib/extensions. Any opposition in me moving this bundle ? Regards Felix

[jira] [Assigned] (SLING-4176) Sightly: StyleToken context is doing nothing

[ https://issues.apache.org/jira/browse/SLING-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reassigned SLING-4176: Assignee: Felix Meschberger > Sightly: StyleToken context is doing nothing > --

[jira] [Resolved] (SLING-4182) Cleanup Sightly Engine dependencies

[ https://issues.apache.org/jira/browse/SLING-4182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-4182. -- Resolution: Fixed Good point about not using Commons IO 2.0. Yet, instead of going to 2.

[jira] [Resolved] (SLING-4116) Content length check in JCRNodeResourceMetadata triggers javax.jcr.ItemNotFoundException: No primary item present on node

[ https://issues.apache.org/jira/browse/SLING-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-4116. - Resolution: Fixed > Content length check in JCRNodeResourceMetadata triggers > javax.jcr.

[jira] [Resolved] (SLING-3865) Remove JcrResource.adaptTo(URL

[ https://issues.apache.org/jira/browse/SLING-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3865. - Resolution: Fixed Removed the adaption code > Remove JcrResource.adaptTo(URL > --

[jira] [Commented] (SLING-4184) Provide path mapping from JCR nodes to resource paths

[ https://issues.apache.org/jira/browse/SLING-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217585#comment-14217585 ] Carsten Ziegeler commented on SLING-4184: - I've committed a first version which in

[jira] [Updated] (SLING-4184) Provide path mapping from JCR nodes to resource paths

[ https://issues.apache.org/jira/browse/SLING-4184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-4184: Fix Version/s: JCR Resource 2.3.14 > Provide path mapping from JCR nodes to resource paths >